-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring code in src/api/groups.js #7
Comments
I would like to work on this please! |
Aya-Abdel-Hamid
changed the title
Refactoring code in src/admin/admin.js
Refactoring code in public/src/admin/admin.js
Aug 29, 2024
Aya-Abdel-Hamid
changed the title
Refactoring code in public/src/admin/admin.js
Refactoring code in src/admin/languages.js
Aug 29, 2024
Aya-Abdel-Hamid
changed the title
Refactoring code in src/admin/languages.js
Refactoring code in src/languages.js
Aug 29, 2024
Great! I assigned you (@Aya-Abdel-Hamid) to the issue. Have fun working on it! |
This type of issue shouldn't be labeled as a bug. It pertains to solving a problem that affects code quality rather than functionality. |
Aya-Abdel-Hamid
changed the title
Refactoring code in src/languages.js
Refactoring code in src/loader.js
Aug 29, 2024
Aya-Abdel-Hamid
changed the title
Refactoring code in src/loader.js
Refactoring code in src/api/groups.js
Aug 30, 2024
Aya-Abdel-Hamid
changed the title
Refactoring code in src/api/groups.js
Refactoring code in src/groups/create.js
Aug 30, 2024
Aya-Abdel-Hamid
changed the title
Refactoring code in src/groups/create.js
Refactoring code in src/api/groups.js
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After refactoring the
groupsAPI.join
function to reduce cognitive complexity, the changes introduced multiple test failures, particularly with tests returning unexpected HTTP 500 status codes. The refactor aimed to streamline asynchronous operations, optimize privilege checks, and improve group event logging. However, the revised function appears to mishandle certain scenarios, leading to errors when processing group joins or membership requests. The current focus is on debugging the refactored logic to ensure it correctly handles all cases, resolves the test failures, and maintains efficient code without reintroducing high cognitive complexity.The text was updated successfully, but these errors were encountered: