Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge changes from project 1 in file "groups.data.js" #29

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

rsharaf-dev
Copy link
Collaborator

Refactored this issue "Refactor this function to reduce its Cognitive Complexity from 22 to the 15 allowed."

@khalifat3 khalifat3 merged commit fe805df into f24 Sep 19, 2024
1 check passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10943133435

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 82.673%

Files with Coverage Reduction New Missed Lines %
src/user/approval.js 3 87.61%
Totals Coverage Status
Change from base Build 10942480802: -0.007%
Covered Lines: 22332
Relevant Lines: 25593

💛 - Coveralls

@Abdallah-Abdaljalil Abdallah-Abdaljalil added the p1 Changes related to Project 1 label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 Changes related to Project 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants