Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging KRAARK with p1 #30

Merged
merged 1 commit into from
Sep 19, 2024
Merged

merging KRAARK with p1 #30

merged 1 commit into from
Sep 19, 2024

Conversation

khalifat3
Copy link
Collaborator

Merged changes from Project 1 into this repository.

Changes

Refactored code in src/topics/tags.js to reduce nesting levels. Creating tags is not in a nested function anymore.

@khalifat3 khalifat3 self-assigned this Sep 19, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10943758273

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 82.674%

Totals Coverage Status
Change from base Build 10943248470: 0.001%
Covered Lines: 22333
Relevant Lines: 25594

💛 - Coveralls

Copy link
Collaborator

@rsharaf-dev rsharaf-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Abdallah-Abdaljalil Abdallah-Abdaljalil merged commit 4c8f1d4 into f24 Sep 19, 2024
1 check passed
@Abdallah-Abdaljalil Abdallah-Abdaljalil added the p1 Changes related to Project 1 label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 Changes related to Project 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants