Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic translator service #60

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Add basic translator service #60

merged 4 commits into from
Nov 12, 2024

Conversation

mohamed-elzeni
Copy link
Member

@mohamed-elzeni mohamed-elzeni commented Nov 12, 2024

This adds the basic translator service that returns hard-coded dummy translations. The deployment of the Python app is at https://github.com/mohamed-elzeni/translator-service.

This has been tested by the listing and testing suite. In addition to testing the UI on the deployed NodeBB instance.

@mohamed-elzeni mohamed-elzeni self-assigned this Nov 12, 2024
@mohamed-elzeni mohamed-elzeni added enhancement New feature or request frontend main code is written in frontend backend main code is written in backend labels Nov 12, 2024
@coveralls
Copy link

coveralls commented Nov 12, 2024

Pull Request Test Coverage Report for Build 11802265253

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 82.685%

Totals Coverage Status
Change from base Build 11660254813: 0.005%
Covered Lines: 22372
Relevant Lines: 25636

💛 - Coveralls

@mohamed-elzeni mohamed-elzeni merged commit 1ad806e into f24 Nov 12, 2024
3 checks passed
@mohamed-elzeni mohamed-elzeni requested review from tatougueye and removed request for aattiyah, akobaidan and tatougueye November 12, 2024 18:16
@tatougueye tatougueye requested review from tatougueye and removed request for tatougueye November 12, 2024 18:23
@tatougueye
Copy link

Hey, seems like its working properly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend main code is written in backend enhancement New feature or request frontend main code is written in frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants