Adding user story 9 front-end code issue #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalman3
added
enhancement
Pull Request Test Coverage Report for Build 11260198686Details
💛 - Coveralls |
hibaabdullahhamad
requested changes
Oct 10, 2024
There was a problem hiding this comment.
Great work! Your implementation method is great. However, I believe we should avoid adding console.log statements when merging, do you think we could remove those lines?
In addition, we should name our branches to reflect the work we performed, so what do you think of changing the branch name to something like 'emoji-feature'?
Nice effort!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, I created a new file called emoji-dropdown.tpl that implements a dropdown menu for replying to comments with five different emojis. The purpose of this feature is to enhance user interaction by providing quick access to common emoji reactions.
Changes Made:
New File Creation: I added emoji-dropdown.tpl, which contains the HTML structure for the emoji dropdown. This includes:
A button to toggle the dropdown menu.
A list of five emoji options that users can click to insert into their comments.
To improve the appearance of the emoji buttons, I added specific CSS classes for future adjustments:
Linking the Template: I ensured that the new dropdown file is linked in the appropriate template file using the line in node_modules/nodebb-theme-harmony/templates/partials/topic/post.tpl: