Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged Project 1 changes mthani2 #15

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

mthani2
Copy link

@mthani2 mthani2 commented Sep 19, 2024

Merging my project1 changes to team repo. Refactored code in src/upgrades/1.1.0/user_post_count_per_tid.js.

Refactored the code to reduce the maximum depth of nesting.

Restructured the code to simplify the nested callback structure for updating user post counts per topic identifier (tid), reducing complexity. This was done by simplifying the arrangement of functions and improving readability without changing the core functionality.
The async.each and async.eachSeries functions, were maintained but their syntax and structure were cleaned up to reduce redundancy (solving the maximum depth issue).
The function now works under a single method (directly assigned in the module.exports,) replacing the separate assignment of the action function.

@mthani2 mthani2 added this to the Sprint 1 milestone Sep 19, 2024
@mthani2 mthani2 requested a review from Nalseaf September 19, 2024 12:10
@mthani2 mthani2 self-assigned this Sep 19, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10940668903

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 82.666%

Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
src/groups/join.js 1 92.05%
Totals Coverage Status
Change from base Build 10921357667: -0.02%
Covered Lines: 22322
Relevant Lines: 25582

💛 - Coveralls

@mthani2 mthani2 merged commit 314e8d9 into f24 Sep 20, 2024
1 check passed
@Nalseaf
Copy link

Nalseaf commented Sep 20, 2024

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants