Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Avtp_<Format>_IsValid() functions for all AVTP/ACF frame formats #52

Open
adriaan-niess opened this issue Dec 3, 2024 · 0 comments
Labels
feature good first issue Good for newcomers

Comments

@adriaan-niess
Copy link
Member

adriaan-niess commented Dec 3, 2024

Calling Getters/Setters might access invalid memory regions if the length fields contain false values. A method

bool Avtp_<Format>_IsValid(Avtp_<Format>_t* format, size_t bufferSize)

should be added to every AVTP type/format. This function should:

  • Check if the length field of AVTP/ACF messages contains a value larger than the actual size of the buffer that contains the AVTP message.
  • Check if other format specific invariants are not upheld
@adriaan-niess adriaan-niess changed the title Add Avtp_<Format>_IsValid() functions for different frame formats Add Avtp_<Format>_IsValid() functions for all AVTP/ACF frame formats Dec 3, 2024
@adriaan-niess adriaan-niess added the good first issue Good for newcomers label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant