Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vspec2franca output not complete #148

Closed
kdopen opened this issue Mar 26, 2020 · 7 comments
Closed

vspec2franca output not complete #148

kdopen opened this issue Mar 26, 2020 · 7 comments

Comments

@kdopen
Copy link

kdopen commented Mar 26, 2020

I tried running the output of vspec2franca through franca_ara_tools and it wouldn't transform.

There were two initial issues

  • No package statement in the generated .fidl file
  • No definition of UTF8String used to declare VSS_VERSION

Further, the array declarations seem to initalise fields for signals which are not in the underlying struct, for example the struct is defined as

struct SignalSpec {
    UInt32 id
    String name
    String type
    String description
}

And here's a single signal from the ADAS file

{
    name: "CruiseControl.SpeedSet"
    type: "actuator"
    description: "Set cruise control speed in kilometers per hour"
    datatype: int32
    uuid: 35b910b5452f5fa0a5aa6bb630335c49
    unit: km/h
}

There are no fields declared in the struct for uuid, datatype, or unit and there is no value defined for the id field.

I don't know FRANCA that well, so it's possible this is not a problem.

@klotzbenjamin
Copy link
Contributor

klotzbenjamin commented Mar 26, 2020

The tools are moving to https://github.com/genivi/vss-tools as part of a current effort (#144). I am not familiar with FRANCA either.

@kdopen
Copy link
Author

kdopen commented Mar 26, 2020

So should we move this issue there, or leave it here?

@danielwilms
Copy link
Collaborator

@gunnarx: it really is an issue and has to be looked at. First, mainly PoC usage but useful. Will create new PR.

@gunnarx
Copy link
Contributor

gunnarx commented Mar 31, 2020

@kdopen I will get back to you on this.
You are right and I think there is a completely different translation that should be done in Franca than the one made here. Something more like this: https://github.com/gunnarx/vehicle_signal_specification/blob/franca_attributes/tools/vspec2franca_attributes.py
(might need a bit of cleanup)

@gunnarx
Copy link
Contributor

gunnarx commented Mar 31, 2020

So should we move this issue there, or leave it here?

No problem to keep it here now. We will switch over to the other organization relatively soon but the change proposal #144 has not been closed yet.

@gunnarx
Copy link
Contributor

gunnarx commented Jun 2, 2020

See above reference for the implementation proposal

@erikbosch
Copy link
Collaborator

I am doing some cleanup closing all issues created 2021 or earlier where there have been no activity 2023 or later. If you still consider this issue relevant feel free to reopen it add and add a comment on how you would like to see progress on this one.

@erikbosch erikbosch closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants