Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip push package to GitHub Container Registry #409

Open
CarrotManMatt opened this issue Feb 6, 2025 · 3 comments
Open

Skip push package to GitHub Container Registry #409

CarrotManMatt opened this issue Feb 6, 2025 · 3 comments
Labels
bug Something isn't working deployment Changes to the deployment or CI/CD configuration high priority Needs focus/attention as soon as possible

Comments

@CarrotManMatt
Copy link
Member

In the GitHub workflow to check that the container build correctly, the docker build-push action is used. The push flag should be set to false if the PR is being made from a repository forked from the main project. Pushing will always fail because forked repositories do not have access to push to the GHCR.

Although this will be a limitation on the efficacy of the check/test, there is no full solution. The build check will still occur and any issues with pushing to the GHCR will present themselves after the PR is merged.

@CarrotManMatt CarrotManMatt added bug Something isn't working deployment Changes to the deployment or CI/CD configuration high priority Needs focus/attention as soon as possible labels Feb 6, 2025
@MattyTheHacker
Copy link
Member

any issues with pushing to the GHCR will present themselves after the PR is merged. - the ultimate test in prod

@MattyTheHacker
Copy link
Member

Rather than skipping - in theory could you write an action that takes the PR, copies it to a local branch and then does the push and dev deploy?

@CarrotManMatt
Copy link
Member Author

That sounds absolutely horrendous. I'd also rather not pull unverified code from someones fork inside the project where it is then privileged to run actions without manual approval. A good GitHub feature that i like is that fork PRs need approval to run checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deployment Changes to the deployment or CI/CD configuration high priority Needs focus/attention as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants