Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you add the option to use a bigger font? #47

Open
collinator24 opened this issue Dec 3, 2018 · 10 comments
Open

Can you add the option to use a bigger font? #47

collinator24 opened this issue Dec 3, 2018 · 10 comments

Comments

@collinator24
Copy link

Can you add the option to use a bigger font? I want to make a store with my friends on my server but the max font size is super small, even when I manually update the number past the slider it does not change it.

@Cherry
Copy link
Owner

Cherry commented Dec 6, 2018

Hey, thanks for the suggestion. The font is explicitly clamped at 100 max right now to prevent abuse.

size = math.Clamp(size, 1, 100)

I'm not really sure I want to increase this limit. Can you show me a use-case where the font is too small?

@collinator24
Copy link
Author

collinator24 commented Dec 7, 2018 via email

@Cherry
Copy link
Owner

Cherry commented Dec 7, 2018

Not currently, no. From testing, 100 is a good medium between being invasive and being too small. I'd be happy to consider increasing the limit if you can provide a good use-case. 😃 Do you have some screenshots of where you'd want to see the text bigger?

@mcNuggets1
Copy link

mcNuggets1 commented Dec 7, 2018

I think 100 is the limit in general for all fonts.
I still get these e-mail notifications from an account, I already deleted.
So I am here again.

@collinator24
Copy link
Author

collinator24 commented Dec 7, 2018 via email

@collinator24
Copy link
Author

collinator24 commented Dec 7, 2018 via email

@mcNuggets1

This comment has been minimized.

@collinator24
Copy link
Author

collinator24 commented Dec 7, 2018 via email

@Cherry
Copy link
Owner

Cherry commented Dec 7, 2018

@mcNuggets1 No need to be aggressive. @collinator24 was just asking a very reasonable question. 😃 I'm going to lock this now - I have all the information I need and will get back to you if this is something I want to change in the future.

Thanks again for the suggestion!

Repository owner locked as too heated and limited conversation to collaborators Dec 7, 2018
@Cherry Cherry added the on-hold label Dec 7, 2018
Repository owner unlocked this conversation Jul 9, 2020
@TomDotBat
Copy link
Contributor

Just make a config variable and default it to 100. Easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants