-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch baseDir to http.FileSystem #4
Comments
FWIW, I think this is a fantastic idea. 👍 |
@shurcooL Thanks for the feedback! This looks feasible, and #5 was the first step towards this. The challenge is that some of the original functions were written with the assumption that the file would be available locally. Any calls to I also need to think of how we would test for this given our current testing setup. As I understand it, we can't just test that the current tests work with the new logic. Since our test environment does provide access to the local filesystem, even if we pass in the base directory with There's probably a way around this; I'll need to think what it would be. |
any more thoughts/plans on this one? |
Hi!
http.FileSystem would allow to operate in remotes, too.
For locals you would just throw in 'http.Dir(baseDir)'.
The text was updated successfully, but these errors were encountered: