Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split DeviceModule::reportException #135

Closed
3 tasks done
killenb opened this issue Apr 6, 2020 · 5 comments
Closed
3 tasks done

split DeviceModule::reportException #135

killenb opened this issue Apr 6, 2020 · 5 comments
Assignees

Comments

@killenb
Copy link
Member

killenb commented Apr 6, 2020

Child of #123

Currently DeviceModule::reportException() does two things:

  • It reports the exception to the device module
  • It waits until the device has recovered before it returns

The latter is should not always happen according to the new spec, and the waiting has to happen at a different place.

Task:

  • Move the part which is waiting for recovery into a function void waitForRecovery(), so reportException
  • In all places where reportException() is now called, add waitForRecovery() after it so the functionality does not change.
  • All tests should still work at this point.

The refactoring of the ExceptionHandlingDecorator to correctly use the non-blocking reporting and then wait at a different place will be implemented in tickets #130, #138 and/or #139.

Implementeshttps://chimeratk.github.io/ApplicationCore/master/exception_handling_design.html 4.2.1 and 4.2.2. Resolves specification issue 11.17 and 11.18

@killenb
Copy link
Member Author

killenb commented Apr 6, 2020

Fixes spec 11.17 and 11.18

@jhktimm jhktimm self-assigned this Apr 7, 2020
@jhktimm
Copy link
Contributor

jhktimm commented Apr 9, 2020

I think the name waitForException for this function is a mistake here? there is no waiting for it but a report. So I keep reportException(withou waiting for recovery) and add new function waitForRecovery().

jhktimm added a commit that referenced this issue Apr 9, 2020
	-waitting for recovery is now outsourced in function
	DeviceModule::waitForRecovery()

	-everywhere where the function is called, the new function is now called.
@killenb
Copy link
Member Author

killenb commented Apr 9, 2020

Fixed it in the descrption

@jhktimm jhktimm added the review label Apr 14, 2020
@jhktimm
Copy link
Contributor

jhktimm commented Apr 14, 2020

Äh. How do i close this ticket? I can label it to review...

@killenb killenb removed the review label Apr 14, 2020
@killenb
Copy link
Member Author

killenb commented Apr 14, 2020

Just close it. I have to check all tickets in closed state anyway.

@killenb killenb closed this as completed Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants