-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split DeviceModule::reportException #135
Comments
Fixes spec 11.17 and 11.18 |
I think the name waitForException for this function is a mistake here? there is no waiting for it but a report. So I keep reportException(withou waiting for recovery) and add new function waitForRecovery(). |
jhktimm
added a commit
that referenced
this issue
Apr 9, 2020
-waitting for recovery is now outsourced in function DeviceModule::waitForRecovery() -everywhere where the function is called, the new function is now called.
Fixed it in the descrption |
Äh. How do i close this ticket? I can label it to review... |
Just close it. I have to check all tickets in closed state anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Child of #123
Currently DeviceModule::reportException() does two things:
The latter is should not always happen according to the new spec, and the waiting has to happen at a different place.
Task:
void waitForRecovery()
, so reportExceptionThe refactoring of the ExceptionHandlingDecorator to correctly use the non-blocking reporting and then wait at a different place will be implemented in tickets #130, #138 and/or #139.
Implementeshttps://chimeratk.github.io/ApplicationCore/master/exception_handling_design.html 4.2.1 and 4.2.2. Resolves specification issue 11.17 and 11.18
The text was updated successfully, but these errors were encountered: