Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to changes in ChimeraTK/DeviceAccess#117 #25

Closed
3 tasks done
killenb opened this issue Apr 9, 2020 · 0 comments
Closed
3 tasks done

Adapt to changes in ChimeraTK/DeviceAccess#117 #25

killenb opened this issue Apr 9, 2020 · 0 comments
Assignees
@ckampm

Comments

@killenb
Copy link
Member

killenb commented Apr 9, 2020 •
edited by ckampm
Loading

Child of ChimeraTK/ApplicationCore#123

All the doXxxTransfer functions must not be called any more. You have to use xxxTransfer (without do) any more. Currently the code does not even compile any more because the doXxxTransfer functions are now protected.

  • Make the code compile again
  • Check that doXxxTransfer functions are not called anywhere else. A decorator might be allowed to access the protected function.
  • Check that all tests are still OK. There should be no functional change.
@ckampm ckampm self-assigned this Apr 9, 2020
ckampm pushed a commit that referenced this issue Apr 9, 2020
Adapt to changes in DeviceAccess #117 (solves #25)
e008a88
@ckampm ckampm closed this as completed Apr 9, 2020
mhier pushed a commit that referenced this issue Mar 16, 2023
@d-rothe
Wip/11221 modernize cmake (#25)
4d87627 
This provides ChimeraTK::<project-name> as cmake imported target.
Variables <project_name>_INCLUDE_DIRS, <project_name>LIBRARY_DIRS, <project_name>_LIBRARIES, <project_name>_CXX_FLAGS, <project_name>_LINKER_FLAGS are provided for compatibility but are generated from cmake-exports where possible and cmake imported targets should be preferred.

* provide function for option array conversion
to be used with target_compile_options etc + FindPackage results, where
findPackage results are of incorrect/old format

* FindDOOCS:
 - DOOCS components as imported targets
 - clean up no longer needed tweaks
 - add timinglib as component
 - make use of log levels and respect QUIET argument

* add_dependency: fail on wrong add_dependency usage
this was unseen since it worked in most cases but in general does not
in particular was causing trouble with imports from cppext
second arg must be version number

* pkgconfig exports
 - generated from cmake-exports
 - make linker flags come before libs, order is required e.g. for --no-as-needed flag
 - remove duplicates in output

* FindGccAtomic
- do not put absolute lib path in output since it was causing trouble with yocto builds. Should be in system lib
paths anyway. Also, make GccAtomic variable output name more consistent.
mhier added a commit that referenced this issue Mar 16, 2023
@mhier
Merge pull request #70 from ChimeraTK/update-project-template
4bf27a0 
Wip/11221 modernize cmake (#25)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckampm ckampm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@killenb @ckampm