Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with ESLint 7.x #114

Open
groenroos opened this issue Oct 6, 2021 · 0 comments
Open

Compatibility with ESLint 7.x #114

groenroos opened this issue Oct 6, 2021 · 0 comments

Comments

@groenroos
Copy link

The "eslint": ">=6" peer dependency constraint makes npm refuse to install this in my project using ESLint 7;

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: undefined@undefined
npm ERR! Found: [email protected]
npm ERR! node_modules/eslint
npm ERR!   peer eslint@">=7.5.0" from @babel/[email protected]
npm ERR!   node_modules/@babel/eslint-parser
npm ERR!     @babel/eslint-parser@"^7.12.16" from [email protected]
npm ERR!     node_modules/eslint-template-visitor
npm ERR!       eslint-template-visitor@"^2.3.2" from [email protected]
npm ERR!       node_modules/eslint-plugin-unicorn
npm ERR!         eslint-plugin-unicorn@"^36.0.0" from [email protected]
npm ERR!         node_modules/xo
npm ERR!     dev @babel/eslint-parser@"^7.15.7" from the root project
npm ERR!   peer eslint@"^5.0.0 || ^6.0.0 || ^7.0.0" from @typescript-eslint/[email protected]
npm ERR!   node_modules/@typescript-eslint/eslint-plugin
npm ERR!     peer @typescript-eslint/eslint-plugin@">=4.32.0" from [email protected]
npm ERR!     node_modules/eslint-config-xo-typescript
npm ERR!       eslint-config-xo-typescript@"^0.45.0" from [email protected]
npm ERR!       node_modules/xo
npm ERR!         dev xo@"^0.45.0" from the root project
npm ERR!     @typescript-eslint/eslint-plugin@"^4.32.0" from [email protected]
npm ERR!     node_modules/xo
npm ERR!       dev xo@"^0.45.0" from the root project
npm ERR!   18 more (@typescript-eslint/experimental-utils, eslint-utils, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! dev eslint-config-xo-vue@"*" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/eslint
npm ERR!   peer eslint@"^5.0.0 || ^6.0.0" from [email protected]
npm ERR!   node_modules/eslint-plugin-vue
npm ERR!     peer eslint-plugin-vue@"^6.2.1" from [email protected]
npm ERR!     node_modules/eslint-config-xo-vue
npm ERR!       dev eslint-config-xo-vue@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Using --legacy-peer-deps results in an error when trying to run XO;

Error: BaseConfig » /node_modules/eslint-config-xo-vue/index.js:
	Configuration for rule "unicorn/prevent-abbreviations" is invalid:
	Value {"whitelist":{"props":true,"assetsDir":true}} should NOT have additional properties.

    at ConfigValidator.validateRuleOptions (/node_modules/@eslint/eslintrc/lib/shared/config-validator.js:144:23)
    at /node_modules/@eslint/eslintrc/lib/shared/config-validator.js:199:18
    at Array.forEach (<anonymous>)
    at ConfigValidator.validateRules (/node_modules/@eslint/eslintrc/lib/shared/config-validator.js:196:34)
    at ConfigValidator.validateConfigArray (/node_modules/@eslint/eslintrc/lib/shared/config-validator.js:322:18)
    at CascadingConfigArrayFactory._finalizeConfigArray (/node_modules/@eslint/eslintrc/lib/cascading-config-array-factory.js:493:23)
    at CascadingConfigArrayFactory.getConfigArrayForFile (/node_modules/@eslint/eslintrc/lib/cascading-config-array-factory.js:299:21)
    at CLIEngine.isPathIgnored (/node_modules/eslint/lib/cli-engine/cli-engine.js:973:18)
    at ESLint.isPathIgnored (/node_modules/eslint/lib/eslint/eslint.js:688:26)
    at runEslint (file://node_modules/xo/index.js:31:31)

Is there a way to make this plugin happy with ESLint 7?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant