Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog touch-action set to none intentionally? #1197

Open
jjvaris opened this issue Dec 28, 2023 · 1 comment
Open

Dialog touch-action set to none intentionally? #1197

jjvaris opened this issue Dec 28, 2023 · 1 comment
Labels
question Issue is a question.

Comments

@jjvaris
Copy link

jjvaris commented Dec 28, 2023

Question

Describe your issue. Be as precice as possible.

In Dialog, the container div has the property touch-action: none; set. Now it is not possible to zoom or scroll on mobile when the dialog is open. Is this intentional? On the desktop, the scroll and zoom are possible.

In case, the user is using a small mobile device, large font, landscape orientation etc. it is possible that the dialog does not fit the screen.

I believe using the scrollable prop in Dialog is not recommended "just in case".

Additional context

Add any other context about the problem here. You may also attach screenshots or links if needed.

https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action#accessibility_concerns

Screenshot 2023-12-28 at 8 56 36 Screenshot 2023-12-28 at 9 06 37

Scroll works, If touch-action set to auto:

[class*='Dialog-module_dialogContainer'] {
  touch-action: auto;
}
Screen.Recording.2023-12-28.at.9.07.13.mov
Screenshot 2023-12-28 at 9 10 13 Screenshot 2023-12-28 at 9 10 44
@jjvaris jjvaris added the question Issue is a question. label Dec 28, 2023
@laurakarhu
Copy link
Contributor

Thank you for your good question!
It was set related to some scrolling problems in iOS, but it is true that this can cause other problems. We are looking this more throughly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Issue is a question.
Projects
None yet
Development

No branches or pull requests

2 participants