New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Pindora client to support seasonal booking and reservation series #1502

Merged

github-actions merged 28 commits into main from update-pindora-client

Feb 4, 2025

Collaborator

matti-lamppu commented Jan 22, 2025 •

edited

Loading

🛠️ Changelog

Updates the Pindora client to support seasonal bookings and reservation series
Adds caching support to the client
Adds retrying to all external clients

🧪 Test plan

Automated tests

🚧 Dependencies

None

🎫 Tickets

None

matti-lamppu added the improvement label

matti-lamppu self-assigned this

matti-lamppu marked this pull request as ready for review

January 22, 2025 12:34

matti-lamppu requested review from ranta and vergama

January 22, 2025 12:34

vergama reviewed

View reviewed changes

tilavarauspalvelu/integrations/keyless_entry/client.py Outdated Show resolved Hide resolved

vergama reviewed

View reviewed changes

tilavarauspalvelu/integrations/keyless_entry/client.py Outdated Show resolved Hide resolved

vergama reviewed

View reviewed changes

tilavarauspalvelu/integrations/keyless_entry/client.py Outdated Show resolved Hide resolved

vergama reviewed

View reviewed changes

tilavarauspalvelu/integrations/keyless_entry/client.py Outdated Show resolved Hide resolved

vergama reviewed

View reviewed changes

tilavarauspalvelu/integrations/keyless_entry/client.py Outdated Show resolved Hide resolved

vergama requested changes

View reviewed changes

vergama left a comment

Series and seasonal creation and (more importantly) update should be limited to only their CONFIRMED reservations.

ranta approved these changes

View reviewed changes

tilavarauspalvelu/integrations/keyless_entry/typing.py Outdated Show resolved Hide resolved

tilavarauspalvelu/integrations/keyless_entry/client.py Outdated Show resolved Hide resolved

tilavarauspalvelu/integrations/keyless_entry/client.py Outdated Show resolved Hide resolved

matti-lamppu force-pushed the refactor-reservations-api branch from 28ff058 to 8aea484 Compare

January 23, 2025 06:40

matti-lamppu force-pushed the update-pindora-client branch from b777f70 to 54223cf Compare

January 23, 2025 06:40

matti-lamppu requested review from vergama and ranta

January 23, 2025 07:26

vergama approved these changes

View reviewed changes

matti-lamppu force-pushed the update-pindora-client branch 2 times, most recently from d0417b6 to 934c1df Compare

January 24, 2025 07:43

ranta reviewed

View reviewed changes

tilavarauspalvelu/integrations/keyless_entry/typing.py Outdated Show resolved Hide resolved

vergama reviewed

View reviewed changes

utils/external_service/base_external_service_client.py Outdated Show resolved Hide resolved

matti-lamppu force-pushed the update-pindora-client branch 3 times, most recently from 3f0d80b to 709e6a2 Compare

January 27, 2025 13:05

vergama reviewed

View reviewed changes

tests/helpers.py Outdated Show resolved Hide resolved

vergama approved these changes

View reviewed changes

matti-lamppu force-pushed the update-pindora-client branch from 09de51a to 9a0370c Compare

January 28, 2025 13:25

Collaborator Author

matti-lamppu commented Jan 29, 2025 •

edited

Loading

Merged #1503, #1505, #1506, #1507, #1509, #1510 to this PR so that I don't need to rebase so many PRs at once...

matti-lamppu force-pushed the refactor-reservations-api branch from aed4906 to c05a139 Compare

January 29, 2025 10:54

matti-lamppu force-pushed the update-pindora-client branch from 268dc53 to 5fdc254 Compare

January 29, 2025 10:54

matti-lamppu added 24 commits

February 4, 2025 18:50


          Add different exception classes for different errors

e561429

This allows treating them differently on use


          Fix retry logic in BaseExternalClient

f644c05


          Refactor PindoraClient to new separate PUT endpoints

b9cf49b


          Fix and simplify mocking logic in external clients

5f0415b


          Fix typo in use_retires decorator

4df83ec


          Allow UUIDs to some PindoraClient methods in place of models

30133e7

This is to allow using them when the model has been removed


          Add caching support to PindoraClient

9500d1c


          Add access type fields to reservations and statistics

ba5637a


          Add access code creation to reservation creation

e7a5cdc


          Create access code in Pindora on staff create

486f530


          Update access code active state when reservation state changes

a787f7d


          Update access code in Pindora on reservation reschedule

ffbdc5c


          Delete access code on cancellation, deny, or inactive prune

bb49370


          Make Pindora info available from the reservation GraphQL type

04cbc05


          Add tasks for activating access codes on failure

ffb25ff


          Create an access code when approving a reservation without one

e9c3aa6

This can happen in a denied reservation returns to handling and is
then approved. Also modify return to handling mutation to not make
the deactivate call if access code was removed.


          Add reservation unit UUID to admin panel

9546cab


          Add Pindora API response to admin panel

58977d1


          Fix admin panel tests

3ac3bb5


          Restrict some access type fields to staff in Reservation type

124a183


          Purge pindora caches on PUT or DELETE requests

018cf8b


          Don't show Pindora infor 24 hours after reservation has ended

684e319


          Update reservation access types with reservation unit access type

a2d321d


          Exclude recurring reservation reservations from Pindora updates

e333b61

matti-lamppu force-pushed the update-pindora-client branch from 82c739f to e333b61 Compare

February 4, 2025 16:51


          Add caching to client methods internally

cacaf04

Removes need to use caching method manually

sonarqubecloud bot commented Feb 4, 2025

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Collaborator Author

matti-lamppu commented Feb 4, 2025

/ff

github-actions bot merged commit cacaf04 into main

19 checks passed

github-actions bot deleted the update-pindora-client branch

February 4, 2025 17:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature improvement