#1134 add data-sources tag to active DAGs #1135
Merged
+10
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmnata
reviewed
Jan 15, 2025
dags/citywide_tti_aggregate.py
Outdated
| @@ -48,7 +48,7 @@ | |||
| default_args=default_args, | |||
| schedule=None, # gets triggered by HERE dag | |||
| doc_md = doc_md, | |||
| tags=["HERE"], | |||
| tags=["bdit_data-sources", "HERE"], | |||
chmnata
reviewed
Jan 15, 2025
dags/tti_aggregate.py
Outdated
| @@ -45,7 +45,7 @@ | |||
| default_args=default_args, | |||
| schedule=None, # gets triggered by HERE dag | |||
| doc_md = doc_md, | |||
| tags=["HERE"], | |||
| tags=["bdit_data-sources", "HERE"], | |||
chmnata
reviewed
Jan 15, 2025
dags/vds_pull_vdsvehicledata.py
Outdated
| @@ -44,7 +44,7 @@ | |||
| os.path.join(repo_path,'dags/sql') | |||
| ], | |||
| doc_md=DOC_MD, | |||
| tags=['vds', 'vdsvehicledata', 'data_checks', 'pull'], | |||
| tags=["bdit_data-sources", 'vds', 'vdsvehicledata', 'data_checks', 'pull'], | |||
There was a problem hiding this comment.
are we doing data_pull or pull ?
chmnata
reviewed
Jan 15, 2025
dags/gcc_layers_pull.py
Outdated
| @@ -24,7 +24,7 @@ def create_gcc_puller_dag(dag_id, default_args, name, conn_id): | |||
| dag_id=dag_id, | |||
| default_args=default_args, | |||
| catchup=False, | |||
| tags=['gcc', name], | |||
| tags=["bdit_data-sources", 'gcc', name], | |||
There was a problem hiding this comment.
I see some other DAG has yearly and monthly if its not running daily, then I think this should also have quarterly
chmnata
approved these changes
Jan 15, 2025
gabrielwol
deleted the
1134-add-data-sources-tag-to-dags-to-make-identifying-them-easier-on-morbius-in-particular
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pull request accomplishes:
Issue(s) this solves:
What, in particular, needs to reviewed:
What needs to be done by a sysadmin after this PR is merged
Pull changes into data_scripts