Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cc-addon-elasticsearch-option: make monthlyCost optional #1230

Open
florian-sanders-cc opened this issue Nov 7, 2024 · 0 comments · May be fixed by #1295
Open

cc-addon-elasticsearch-option: make monthlyCost optional #1230

florian-sanders-cc opened this issue Nov 7, 2024 · 0 comments · May be fixed by #1295

Comments

@florian-sanders-cc
Copy link
Contributor

Context

The cc-addon-elasticsearch-option component requires a monthlyCost for APM & Kibana. This property is used to generate the warning about estimated cost.

image

Since it can be used in a context where APM & Kibana have no cost (for instance in a console where everything is free 💸), this property should be optional.

If no monthlyCost is provided, the text about cost estimation should be hidden.

We could also introduce a more sophisticated type for this with a boolean to enable / disable cost estimation.
florian-sanders-cc added a commit that referenced this issue Jan 9, 2025
@florian-sanders-cc
feat(cc-addon-elasticsearch-options)!: support multi-currency & disab…
9468802 
…led billing

BREAKING CHANGE: the `options` property has been replaced with a `state`
property

- the `options` property & attribute have been removed,
- a `state` property & attribute have been added instead,
  - the `state.type` property can be used to set the component in
    `loading` or `loaded` state,
  - in `loading` state, the component shows skeletons instead of flavor
    info and cost info (if monthly cost is enabled) for APM and Kibana options,
  - the `state.hasMonthlyCost` property can be used to enable / disable
    the display of cost info (enabled by default),
  - the `state.options` can be used to pass options to display,
  - on each option, the `flavor.monthlyCost` can be used to set the
    `amount` and the `currency` to display (`loaded` state only).

Fixes #1172
Fixes #1230
florian-sanders-cc added a commit that referenced this issue Jan 10, 2025
@florian-sanders-cc
feat(cc-addon-elasticsearch-options)!: support multi-currency & disab…
0ef2618 
…led billing

BREAKING CHANGE: the `options` property has been replaced with a `state`
property

- the `options` property & attribute have been removed,
- a `state` property & attribute have been added instead,
  - the `state.type` property can be used to set the component in
    `loading` or `loaded` state,
  - in `loading` state, the component shows skeletons instead of flavor
    info and cost info (if monthly cost is enabled) for APM and Kibana options,
  - the `state.hasMonthlyCost` property can be used to enable / disable
    the display of cost info (enabled by default),
  - the `state.options` can be used to pass options to display,
  - on each option, the `flavor.monthlyCost` can be used to set the
    `amount` and the `currency` to display (`loaded` state only).

Fixes #1172
Fixes #1230
@florian-sanders-cc florian-sanders-cc linked a pull request Jan 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@florian-sanders-cc