Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cc-select: introduce a readonly property #1299

Open
florian-sanders-cc opened this issue Jan 16, 2025 · 1 comment
Open

cc-select: introduce a readonly property #1299

florian-sanders-cc opened this issue Jan 16, 2025 · 1 comment
Assignees
Labels
a11y Related to accessibility enhancement New feature or request

Comments

@florian-sanders-cc
Copy link
Contributor

Context

With #1102, we decided to stop relying on the disabled attribute during API calls and use the readonly (for cc-input-* components) / waiting (for cc-button) attribute instead.

We need to have the same logic for the cc-select component but it doesn't expose any readonly attribute at the moment.

We need to add a readonly attribute / property to the cc-select component.

@florian-sanders-cc florian-sanders-cc self-assigned this Jan 16, 2025
@florian-sanders-cc florian-sanders-cc added enhancement New feature or request a11y Related to accessibility labels Jan 16, 2025
@pdesoyres-cc
Copy link
Contributor

See below what we need to do to make a select readonly:

// todo: remove this filter and replace by a proper `readonly` property once `<cc-select>` supports it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Related to accessibility enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants