Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defining the diffID Generation Order in the Model Spec #22

Open
gaius-qi opened this issue Jan 10, 2025 · 3 comments
Open

Defining the diffID Generation Order in the Model Spec #22

gaius-qi opened this issue Jan 10, 2025 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@gaius-qi
Copy link
Contributor

gaius-qi commented Jan 10, 2025

Model Spec uses files as layers and image layers have a sequential relationship, it should define a fixed order for generating diffIDs of files within a directory.

If use application/vnd.oci.image.config.v1+json as config media type now, Model Spec should consider how to define the generation logic of diffIDs to prevent containerd from generating different snapshots.

If use application/vnd.cnai.model.config.v1+json as config media type, the definition of diffIDs can be ignored, refer to #19 (comment).

@gaius-qi gaius-qi added the enhancement New feature or request label Jan 10, 2025
@gaius-qi gaius-qi self-assigned this Jan 10, 2025
@gaius-qi
Copy link
Contributor Author

Generating diffIDs in alphabetical order by file name is a simple solution.

@gorkem
Copy link

gorkem commented Jan 10, 2025

I think the main issue is using the application/vnd.oci.image.config.v1+json as mediaType which makes it an invalid OCI Artifact.

@amisevsk
Copy link

I'm not sure I'm following here -- could you perhaps share an example of the problem?

DiffIDs in my understanding refer to something very specific (which only really applies to container images, not artifacts). Are we talking about the order of layers in the manifest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants