You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
in #217 I made a mistake while using github to merge the master branch into a pr before merging that pr, because of this the xml has been broken for 15 minutes until I noticed while merging the next pr. the updating of the version number goes wrong on numerous occasions as well.
the current workflow for updating the version number works well but does not have the permissions to push to forks (this would require us to make a bot account with such permissions, it's not possible to give the default token such permissions).
it's also still possible to merge before the workflow completes, skipping the version increase. a workaround would be to use github's "auto-merge" feature which will merge after workflows complete.
instead I think the best solution is to disallow prs to be merged altogether and instead have only the workflow be able to merge prs while updating the version automatically. this works around needing a bot account as well as early merges, it does mean we'll need to keep an alternative trigger condition for this merging (eg an approval) and we could suffer some issues if the workflow implementation isn't foolproof.
The text was updated successfully, but these errors were encountered:
in #217 I made a mistake while using github to merge the master branch into a pr before merging that pr, because of this the xml has been broken for 15 minutes until I noticed while merging the next pr. the updating of the version number goes wrong on numerous occasions as well.
the current workflow for updating the version number works well but does not have the permissions to push to forks (this would require us to make a bot account with such permissions, it's not possible to give the default token such permissions).
it's also still possible to merge before the workflow completes, skipping the version increase. a workaround would be to use github's "auto-merge" feature which will merge after workflows complete.
instead I think the best solution is to disallow prs to be merged altogether and instead have only the workflow be able to merge prs while updating the version automatically. this works around needing a bot account as well as early merges, it does mean we'll need to keep an alternative trigger condition for this merging (eg an approval) and we could suffer some issues if the workflow implementation isn't foolproof.
The text was updated successfully, but these errors were encountered: