Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enforce unit tests for nvme sensor #2

Open
drakedog2008 opened this issue Sep 25, 2023 · 0 comments
Open

enforce unit tests for nvme sensor #2

drakedog2008 opened this issue Sep 25, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@drakedog2008
Copy link

drakedog2008 commented Sep 25, 2023 •
edited
Loading

The unit test here is to manually trigger a destruction of nvme instance and check the resource recollection status. Is it designed to prevent the resource is held by some async event and never get the chance to release.

The unit test is using ObjectMapper as a observer so it require Dbus and O-M to be enabled in the docker image. We could enforce the feature for presubmit.

https://gbmc.googlesource.com/meta-gbmc-staging/+/refs/heads/gbmc-release-23.18.x/recipes-phosphor/sensors/dbus-sensors/0030-nvmesensor-add-unit-test.patch
@drakedog2008 drakedog2008 mentioned this issue Sep 25, 2023
Closed
@jk-ozlabs jk-ozlabs added the enhancement New feature or request label Sep 25, 2023
@jk-ozlabs jk-ozlabs changed the title [FR] enforcing the unit test for nvme sensor enforce unit tests for nvme sensor Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jk-ozlabs @drakedog2008