Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM Vulnerabilities #9

Open
valioprea opened this issue Sep 24, 2024 · 1 comment
Open

NPM Vulnerabilities #9

valioprea opened this issue Sep 24, 2024 · 1 comment

Comments

@valioprea
Copy link

When I download this kit & do npm install - I get some vulnerabilities, 3 moderate and 5 high. I'm not a node dev, not sure exactly how to address them, I'd fix them myself.

@jonathan-durbin
Copy link

jonathan-durbin commented Oct 17, 2024

When I ran npm audit fix it resolved almost all of the issues. There's just one high priority issue left, which is @sherby/eleventy-plugin-files-minifier's dependency on html-minifier, which has a ReDoS vulnerability.

@ItsEthanH, it looks like most people are moving to html-minifier-terser from the original html-minifier, which might have been abandoned. Is the fix to simply replace the dependency in node_modules/@sherby/eleventy-plugin-files-minifier/package.json with the terser version? I'm not familiar with node's package management system, so any help is appreciated.

Edit:
After poking around, it looks like

package-lock.json#L821

and

package-lock.json#L2550

might be all that needs to change. But again, as a node novice, I couldn't say for certain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants