Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strengthen Table component #406

Open
MikeLockz opened this issue Nov 11, 2019 · 0 comments
Open

Strengthen Table component #406

MikeLockz opened this issue Nov 11, 2019 · 0 comments
Milestone

Comments

@MikeLockz
Copy link
Contributor

MikeLockz commented Nov 11, 2019

Current Table implement is not flexible enough and does not work out-of-the-box. First step to using the Table is to rewrite the styles as a new styled-component with enough base styles to get it working correct.

For a basic table use-case, the Table component should not need any custom or extended styling to work well responsively.

How would we rewrite this component to no need custom styling to work out of the box?

Acceptance criteria:

  • Should be responsive down to 320px
  • Should not need custom styled elements (th, td, tr)

example of customized table from Storefront :

const StyledTable = styled(RimbleTable)`
  & {
    display: block;
    width: 100%;
    overflow: auto;
    border-width: 0;
  }

  th,
  td {
    border: solid;
    border-width: 1px;
    border-color: inherit;
    padding: 0 1.5rem;
  }
`;

Relates to #420

E: 1D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant