From ea5cdf97547e13e69d63b8b60035243fdabd8f77 Mon Sep 17 00:00:00 2001 From: Gautam Botrel Date: Mon, 22 Apr 2024 16:10:12 -0500 Subject: [PATCH] style: remove old todos (#1106) * style: remove old todos * style: removed TODO for checking staticcall * fix: update version --------- Co-authored-by: Thomas Piellard --- backend/plonk/bls12-377/prove.go | 4 ---- backend/plonk/bls12-381/prove.go | 4 ---- backend/plonk/bls24-315/prove.go | 4 ---- backend/plonk/bls24-317/prove.go | 4 ---- backend/plonk/bn254/prove.go | 4 ---- backend/plonk/bn254/solidity.go | 1 - backend/plonk/bw6-633/prove.go | 4 ---- backend/plonk/bw6-761/prove.go | 4 ---- doc.go | 2 +- .../backend/template/zkpschemes/plonk/plonk.prove.go.tmpl | 4 ---- 10 files changed, 1 insertion(+), 34 deletions(-) diff --git a/backend/plonk/bls12-377/prove.go b/backend/plonk/bls12-377/prove.go index 6c74757478..8dcd0479f0 100644 --- a/backend/plonk/bls12-377/prove.go +++ b/backend/plonk/bls12-377/prove.go @@ -254,8 +254,6 @@ func newInstance(ctx context.Context, spr *cs.SparseR1CS, pk *ProvingKey, fullWi } else { s.domain1 = fft.NewDomain(4*sizeSystem, fft.WithoutPrecompute()) } - // TODO @gbotrel domain1 is used for only 1 FFT → precomputing the twiddles - // and storing them in memory is costly given its size. → do a FFT on the fly // build trace s.trace = NewTrace(spr, s.domain0) @@ -1224,8 +1222,6 @@ func evaluateXnMinusOneDomainBigCoset(domains [2]*fft.Domain) []fr.Element { // - Z_{H}(ζ)*((H₀(X) + ζᵐ⁺²*H₁(X) + ζ²⁽ᵐ⁺²⁾*H₂(X)) func (s *instance) innerComputeLinearizedPoly(lZeta, rZeta, oZeta, alpha, beta, gamma, zeta, zu fr.Element, qcpZeta, blindedZCanonical []fr.Element, pi2Canonical [][]fr.Element, pk *ProvingKey) []fr.Element { - // TODO @gbotrel rename - // l(ζ)r(ζ) var rl fr.Element rl.Mul(&rZeta, &lZeta) diff --git a/backend/plonk/bls12-381/prove.go b/backend/plonk/bls12-381/prove.go index b8060ab811..8e43526322 100644 --- a/backend/plonk/bls12-381/prove.go +++ b/backend/plonk/bls12-381/prove.go @@ -254,8 +254,6 @@ func newInstance(ctx context.Context, spr *cs.SparseR1CS, pk *ProvingKey, fullWi } else { s.domain1 = fft.NewDomain(4*sizeSystem, fft.WithoutPrecompute()) } - // TODO @gbotrel domain1 is used for only 1 FFT → precomputing the twiddles - // and storing them in memory is costly given its size. → do a FFT on the fly // build trace s.trace = NewTrace(spr, s.domain0) @@ -1224,8 +1222,6 @@ func evaluateXnMinusOneDomainBigCoset(domains [2]*fft.Domain) []fr.Element { // - Z_{H}(ζ)*((H₀(X) + ζᵐ⁺²*H₁(X) + ζ²⁽ᵐ⁺²⁾*H₂(X)) func (s *instance) innerComputeLinearizedPoly(lZeta, rZeta, oZeta, alpha, beta, gamma, zeta, zu fr.Element, qcpZeta, blindedZCanonical []fr.Element, pi2Canonical [][]fr.Element, pk *ProvingKey) []fr.Element { - // TODO @gbotrel rename - // l(ζ)r(ζ) var rl fr.Element rl.Mul(&rZeta, &lZeta) diff --git a/backend/plonk/bls24-315/prove.go b/backend/plonk/bls24-315/prove.go index 16d64a5a20..b0e8f4d7cf 100644 --- a/backend/plonk/bls24-315/prove.go +++ b/backend/plonk/bls24-315/prove.go @@ -254,8 +254,6 @@ func newInstance(ctx context.Context, spr *cs.SparseR1CS, pk *ProvingKey, fullWi } else { s.domain1 = fft.NewDomain(4*sizeSystem, fft.WithoutPrecompute()) } - // TODO @gbotrel domain1 is used for only 1 FFT → precomputing the twiddles - // and storing them in memory is costly given its size. → do a FFT on the fly // build trace s.trace = NewTrace(spr, s.domain0) @@ -1224,8 +1222,6 @@ func evaluateXnMinusOneDomainBigCoset(domains [2]*fft.Domain) []fr.Element { // - Z_{H}(ζ)*((H₀(X) + ζᵐ⁺²*H₁(X) + ζ²⁽ᵐ⁺²⁾*H₂(X)) func (s *instance) innerComputeLinearizedPoly(lZeta, rZeta, oZeta, alpha, beta, gamma, zeta, zu fr.Element, qcpZeta, blindedZCanonical []fr.Element, pi2Canonical [][]fr.Element, pk *ProvingKey) []fr.Element { - // TODO @gbotrel rename - // l(ζ)r(ζ) var rl fr.Element rl.Mul(&rZeta, &lZeta) diff --git a/backend/plonk/bls24-317/prove.go b/backend/plonk/bls24-317/prove.go index 1fd43d5169..1e814667b2 100644 --- a/backend/plonk/bls24-317/prove.go +++ b/backend/plonk/bls24-317/prove.go @@ -254,8 +254,6 @@ func newInstance(ctx context.Context, spr *cs.SparseR1CS, pk *ProvingKey, fullWi } else { s.domain1 = fft.NewDomain(4*sizeSystem, fft.WithoutPrecompute()) } - // TODO @gbotrel domain1 is used for only 1 FFT → precomputing the twiddles - // and storing them in memory is costly given its size. → do a FFT on the fly // build trace s.trace = NewTrace(spr, s.domain0) @@ -1224,8 +1222,6 @@ func evaluateXnMinusOneDomainBigCoset(domains [2]*fft.Domain) []fr.Element { // - Z_{H}(ζ)*((H₀(X) + ζᵐ⁺²*H₁(X) + ζ²⁽ᵐ⁺²⁾*H₂(X)) func (s *instance) innerComputeLinearizedPoly(lZeta, rZeta, oZeta, alpha, beta, gamma, zeta, zu fr.Element, qcpZeta, blindedZCanonical []fr.Element, pi2Canonical [][]fr.Element, pk *ProvingKey) []fr.Element { - // TODO @gbotrel rename - // l(ζ)r(ζ) var rl fr.Element rl.Mul(&rZeta, &lZeta) diff --git a/backend/plonk/bn254/prove.go b/backend/plonk/bn254/prove.go index 5e32908260..ee1bd21def 100644 --- a/backend/plonk/bn254/prove.go +++ b/backend/plonk/bn254/prove.go @@ -254,8 +254,6 @@ func newInstance(ctx context.Context, spr *cs.SparseR1CS, pk *ProvingKey, fullWi } else { s.domain1 = fft.NewDomain(4*sizeSystem, fft.WithoutPrecompute()) } - // TODO @gbotrel domain1 is used for only 1 FFT → precomputing the twiddles - // and storing them in memory is costly given its size. → do a FFT on the fly // build trace s.trace = NewTrace(spr, s.domain0) @@ -1224,8 +1222,6 @@ func evaluateXnMinusOneDomainBigCoset(domains [2]*fft.Domain) []fr.Element { // - Z_{H}(ζ)*((H₀(X) + ζᵐ⁺²*H₁(X) + ζ²⁽ᵐ⁺²⁾*H₂(X)) func (s *instance) innerComputeLinearizedPoly(lZeta, rZeta, oZeta, alpha, beta, gamma, zeta, zu fr.Element, qcpZeta, blindedZCanonical []fr.Element, pi2Canonical [][]fr.Element, pk *ProvingKey) []fr.Element { - // TODO @gbotrel rename - // l(ζ)r(ζ) var rl fr.Element rl.Mul(&rZeta, &lZeta) diff --git a/backend/plonk/bn254/solidity.go b/backend/plonk/bn254/solidity.go index 300fef7340..08d0b47113 100644 --- a/backend/plonk/bn254/solidity.go +++ b/backend/plonk/bn254/solidity.go @@ -884,7 +884,6 @@ contract PlonkVerifier { function check_pairing_kzg(mPtr) { let state := mload(0x40) - // TODO test the staticcall using the method from audit_4-5 let l_success := staticcall(gas(), 8, mPtr, 0x180, 0x00, 0x20) if iszero(l_success) { error_pairing() diff --git a/backend/plonk/bw6-633/prove.go b/backend/plonk/bw6-633/prove.go index 9422753443..c4e134320b 100644 --- a/backend/plonk/bw6-633/prove.go +++ b/backend/plonk/bw6-633/prove.go @@ -254,8 +254,6 @@ func newInstance(ctx context.Context, spr *cs.SparseR1CS, pk *ProvingKey, fullWi } else { s.domain1 = fft.NewDomain(4*sizeSystem, fft.WithoutPrecompute()) } - // TODO @gbotrel domain1 is used for only 1 FFT → precomputing the twiddles - // and storing them in memory is costly given its size. → do a FFT on the fly // build trace s.trace = NewTrace(spr, s.domain0) @@ -1224,8 +1222,6 @@ func evaluateXnMinusOneDomainBigCoset(domains [2]*fft.Domain) []fr.Element { // - Z_{H}(ζ)*((H₀(X) + ζᵐ⁺²*H₁(X) + ζ²⁽ᵐ⁺²⁾*H₂(X)) func (s *instance) innerComputeLinearizedPoly(lZeta, rZeta, oZeta, alpha, beta, gamma, zeta, zu fr.Element, qcpZeta, blindedZCanonical []fr.Element, pi2Canonical [][]fr.Element, pk *ProvingKey) []fr.Element { - // TODO @gbotrel rename - // l(ζ)r(ζ) var rl fr.Element rl.Mul(&rZeta, &lZeta) diff --git a/backend/plonk/bw6-761/prove.go b/backend/plonk/bw6-761/prove.go index 9699d598ec..c431940845 100644 --- a/backend/plonk/bw6-761/prove.go +++ b/backend/plonk/bw6-761/prove.go @@ -254,8 +254,6 @@ func newInstance(ctx context.Context, spr *cs.SparseR1CS, pk *ProvingKey, fullWi } else { s.domain1 = fft.NewDomain(4*sizeSystem, fft.WithoutPrecompute()) } - // TODO @gbotrel domain1 is used for only 1 FFT → precomputing the twiddles - // and storing them in memory is costly given its size. → do a FFT on the fly // build trace s.trace = NewTrace(spr, s.domain0) @@ -1224,8 +1222,6 @@ func evaluateXnMinusOneDomainBigCoset(domains [2]*fft.Domain) []fr.Element { // - Z_{H}(ζ)*((H₀(X) + ζᵐ⁺²*H₁(X) + ζ²⁽ᵐ⁺²⁾*H₂(X)) func (s *instance) innerComputeLinearizedPoly(lZeta, rZeta, oZeta, alpha, beta, gamma, zeta, zu fr.Element, qcpZeta, blindedZCanonical []fr.Element, pi2Canonical [][]fr.Element, pk *ProvingKey) []fr.Element { - // TODO @gbotrel rename - // l(ζ)r(ζ) var rl fr.Element rl.Mul(&rZeta, &lZeta) diff --git a/doc.go b/doc.go index 233687841c..73f850a3df 100644 --- a/doc.go +++ b/doc.go @@ -22,7 +22,7 @@ import ( "github.com/consensys/gnark-crypto/ecc" ) -var Version = semver.MustParse("0.10.0-alpha") +var Version = semver.MustParse("0.10.0") // Curves return the curves supported by gnark func Curves() []ecc.ID { diff --git a/internal/generator/backend/template/zkpschemes/plonk/plonk.prove.go.tmpl b/internal/generator/backend/template/zkpschemes/plonk/plonk.prove.go.tmpl index dcd450743e..44b5a9ff28 100644 --- a/internal/generator/backend/template/zkpschemes/plonk/plonk.prove.go.tmpl +++ b/internal/generator/backend/template/zkpschemes/plonk/plonk.prove.go.tmpl @@ -231,8 +231,6 @@ func newInstance(ctx context.Context, spr *cs.SparseR1CS, pk *ProvingKey, fullWi } else { s.domain1 = fft.NewDomain(4*sizeSystem, fft.WithoutPrecompute()) } - // TODO @gbotrel domain1 is used for only 1 FFT → precomputing the twiddles - // and storing them in memory is costly given its size. → do a FFT on the fly // build trace s.trace = NewTrace(spr, s.domain0) @@ -1201,8 +1199,6 @@ func evaluateXnMinusOneDomainBigCoset(domains [2]*fft.Domain) []fr.Element { // - Z_{H}(ζ)*((H₀(X) + ζᵐ⁺²*H₁(X) + ζ²⁽ᵐ⁺²⁾*H₂(X)) func (s *instance) innerComputeLinearizedPoly(lZeta, rZeta, oZeta, alpha, beta, gamma, zeta, zu fr.Element, qcpZeta, blindedZCanonical []fr.Element, pi2Canonical [][]fr.Element, pk *ProvingKey) []fr.Element { - // TODO @gbotrel rename - // l(ζ)r(ζ) var rl fr.Element rl.Mul(&rZeta, &lZeta)