New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing rest_client ownership #28

Open

HatemMn opened this issue Jan 27, 2025 · 1 comment

Assignees

Collaborator

HatemMn commented Jan 27, 2025

when cli commands are run, they shall take ownership of rest client as it's not needed later

Tests, on the other hand, need the rest client variable again so they should be "adapted" to not work with references anymore

Doing this will reduce overall cloning, hence gaining performance

Key files :

crate/cli/src/actions/findex/index_or_delete.rs
crate/cli/src/actions/findex/search.rs
crate/client/src/rest_client.rs

Collaborator Author

HatemMn commented Jan 27, 2025

ideally TB solved within #20 but not prio

HatemMn self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment