Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump samples to java 7 #9

Open
cam72cam opened this issue Sep 20, 2023 · 1 comment
Open

Bump samples to java 7 #9

cam72cam opened this issue Sep 20, 2023 · 1 comment

Comments

@cam72cam
Copy link

In my (limited) testing it looks like java7 should work just fine, even when java 8 breaks forge.

@quat1024
Copy link
Member

quat1024 commented Jan 5, 2024

Sry this is an old comment...! been meaning to pick this project up again

For the actual jdk, I've been using java 8 because it's the easiest to provision with stuff like the gradle toolchains feature, i don't think any older versions are easily available

For sourceCompatibility, im pretty sure minecraft & forge used java 6 at the time so i've been keeping it low to be safe. If 7 works, modders are free to raise it to 7, but i know 8 definitely doesn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants