Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chocolate & Honey localization missing #1476

Closed
cech12 opened this issue Apr 20, 2021 · 2 comments
Closed

Chocolate & Honey localization missing #1476

cech12 opened this issue Apr 20, 2021 · 2 comments
Labels
type: bug Issue where something isn't working

Comments

@cech12
Copy link

cech12 commented Apr 20, 2021

The localization strings fluid.create.chocolate and fluid.create.honey are missing in the generated english localization files:
https://github.com/Creators-of-Create/Create/blob/mc1.16/dev/src/generated/resources/assets/create/lang/en_us.json#L420

If I understand the code right, the localization should be generated like for the other fluids: https://github.com/Creators-of-Create/Create/blob/mc1.16/dev/src/main/java/com/simibubi/create/AllFluids.java#L45
But they aren't generated for some reason.

This leads to an compatibility issue with mods which are using the name of the fluids to show them in the hud like my Ceramic Bucket mod:
cech12/CeramicBucket#49

Thanks for all your work!

@flub9
Copy link

flub9 commented Apr 20, 2021

See #1477 for a hotfix I wrote really quickly.

@SpottyTheTurtle SpottyTheTurtle added type: bug Issue where something isn't working needs input labels Apr 22, 2021
@PepperCode1
Copy link
Member

PepperCode1 commented Jun 11, 2021

Registrate assigns the fluid block's translation key to the fluid as well, which makes it currently impossible to generate these translation keys separately from the block's key. Luckily, doing so is not necessary because Fluid.getAttributes().getTranslationKey() can be used to get the translation key of a fluid. I have opened an issue on the Registrate GitHub (tterrag1098/Registrate#31) that, when solved, will allow more flexibility for fluid language generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issue where something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants