Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modding] Sandpaper polishing doesn't work in sequenced assembly recipes #6626

Open
ivxvm opened this issue Jun 24, 2024 · 0 comments · Fixed by #7259
Open

[Modding] Sandpaper polishing doesn't work in sequenced assembly recipes #6626

ivxvm opened this issue Jun 24, 2024 · 0 comments · Fixed by #7259
Labels
status: fixed in next release Issue will be fixed in the next release type: bug Issue where something isn't working

Comments

@ivxvm
Copy link

ivxvm commented Jun 24, 2024

Describe the Bug

Sandpaper polishing doesn't work in sequenced assembly recipes.

Reproduction Steps

  1. Add a custom sequenced assembly recipe like this (you can replace modded items with any vanilla items, it doesn't matter):
{
  "type": "create:sequenced_assembly",
  "ingredient": {
    "item": "droid_create_diamond_recipe:haunted_scorial_coal"
  },
  "transitionalItem": {
    "item": "droid_create_diamond_recipe:impure_diamond_chunk"
  },
  "sequence": [
    {
      "type": "create:deploying",
      "ingredients": [
        {
          "item": "droid_create_diamond_recipe:impure_diamond_chunk"
        },
        {
          "item": "create:experience_nugget"
        }
      ],
      "results": [
        {
          "item": "droid_create_diamond_recipe:impure_diamond_chunk"
        }
      ]
    },
    {
      "type": "create:cutting",
      "ingredients": [
        {
          "item": "droid_create_diamond_recipe:impure_diamond_chunk"
        }
      ],
      "results": [
        {
          "item": "droid_create_diamond_recipe:impure_diamond_chunk"
        }
      ],
      "processingTime": 50
    },
    {
      "type": "create:deploying",
      "ingredients": [
        {
          "item": "droid_create_diamond_recipe:impure_diamond_chunk"
        },
        {
          "tag": "create:sandpaper"
        }
      ],
      "results": [
        {
          "item": "droid_create_diamond_recipe:impure_diamond_chunk"
        }
      ]
    },
    {
      "type": "create:pressing",
      "ingredients": [
        {
          "item": "droid_create_diamond_recipe:impure_diamond_chunk"
        }
      ],
      "results": [
        {
          "item": "droid_create_diamond_recipe:impure_diamond_chunk"
        }
      ]
    }
  ],
  "results": [
    {
      "item": "droid_create_diamond_recipe:diamond_chunk",
      "count": 1
    }
  ],
  "loops": 2,
  "conditions": [
    {
      "type": "forge:mod_loaded",
      "modid": "create"
    }
  ]
}
  1. Try executing this assembly recipe in game.

Expected Result

First two steps work as expected, but when it comes to deploying sandpaper, assembly line simply stops working, item skips the deployer and proceeds further. Additional note: replacing tag: "create:sandpaper" with item: "create:sand_paper" or even replacing the whole deployer step with type: "create:sandpaper_polishing" doesn't help.

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.1f

Minecraft Version

1.20.1

Forge Version

47.2.20

Other Mods

No response

Additional Context

No response

@ivxvm ivxvm added the type: bug Issue where something isn't working label Jun 24, 2024
@IThundxr IThundxr reopened this Jan 10, 2025
@IThundxr IThundxr added the status: fixed in next release Issue will be fixed in the next release label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: fixed in next release Issue will be fixed in the next release type: bug Issue where something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants