-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fetch method configuration for UpdateSource #248
Comments
It will be great to know if it is a GET or a GIT source for sure. 🙂 |
I have one source that requires a POST, so looking forward to this when it gets added. |
Any ETA on this enhancement? 🙂 |
I'll probably have time to implement this (and probably other features) during the winter break when we have a feature freeze and stage it for a new stable release in 2025 🤞🤞 |
Since you have a source that requires a POST, I assume there's data that has to be sent across in the request (hopefully JSON)? |
In my use case, I think it's just the existing header, but json makes sense for data. |
This should be resolved in the 4.5.0.66 release and all services built under this release. |
We'll need to add a configuration for supplying POST data |
"Probably wouldn't be too unreasonable to add a method field to UpdateSource:
https://cybercentrecanada.github.io/assemblyline4_docs/odm/models/service/#updatesource
And it could be an enum that supports GET, POST, SSH so it'll be more explicit when the updater tries to perform fetching (rather than trial and error that it's doing now)."
Additional context
Ref: https://discord.com/channels/908084610158714900/909870171643056150/1275266906622001172
The text was updated successfully, but these errors were encountered: