Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fetch method configuration for UpdateSource #248

Open
cccs-rs opened this issue Aug 20, 2024 · 8 comments
Open

Add fetch method configuration for UpdateSource #248

cccs-rs opened this issue Aug 20, 2024 · 8 comments
Assignees
Labels
accepted This issue was accepted, we will work on this at some point base enhancement New feature or request service-base service-yara Related to YARA service

Comments

@cccs-rs
Copy link
Contributor

cccs-rs commented Aug 20, 2024

"Probably wouldn't be too unreasonable to add a method field to UpdateSource:
https://cybercentrecanada.github.io/assemblyline4_docs/odm/models/service/#updatesource

And it could be an enum that supports GET, POST, SSH so it'll be more explicit when the updater tries to perform fetching (rather than trial and error that it's doing now)."

Additional context
Ref: https://discord.com/channels/908084610158714900/909870171643056150/1275266906622001172

@cccs-rs cccs-rs added enhancement New feature or request base service-base assess We still haven't decided if this will be worked on or not service-yara Related to YARA service labels Aug 20, 2024
@cccs-rs cccs-rs self-assigned this Aug 20, 2024
@gdesmar
Copy link

gdesmar commented Aug 21, 2024

It will be great to know if it is a GET or a GIT source for sure. 🙂

@eljeffeg
Copy link

I have one source that requires a POST, so looking forward to this when it gets added.

@eljeffeg
Copy link

Any ETA on this enhancement? 🙂

@cccs-rs
Copy link
Contributor Author

cccs-rs commented Nov 13, 2024

I'll probably have time to implement this (and probably other features) during the winter break when we have a feature freeze and stage it for a new stable release in 2025 🤞🤞

@cccs-rs cccs-rs added accepted This issue was accepted, we will work on this at some point and removed assess We still haven't decided if this will be worked on or not labels Dec 5, 2024
@cccs-rs
Copy link
Contributor Author

cccs-rs commented Dec 5, 2024

Since you have a source that requires a POST, I assume there's data that has to be sent across in the request (hopefully JSON)?

@eljeffeg
Copy link

eljeffeg commented Dec 5, 2024

In my use case, I think it's just the existing header, but json makes sense for data.

@cccs-rs
Copy link
Contributor Author

cccs-rs commented Dec 12, 2024

This should be resolved in the 4.5.0.66 release and all services built under this release.

@cccs-rs cccs-rs closed this as completed Dec 12, 2024
@cccs-rs
Copy link
Contributor Author

cccs-rs commented Dec 19, 2024

We'll need to add a configuration for supplying POST data

@cccs-rs cccs-rs reopened this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted This issue was accepted, we will work on this at some point base enhancement New feature or request service-base service-yara Related to YARA service
Projects
None yet
Development

No branches or pull requests

3 participants