Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate removing estimate method in CriterionBase #550

Open
cwschilly opened this issue Sep 28, 2024 · 0 comments
Open

Investigate removing estimate method in CriterionBase #550

cwschilly opened this issue Sep 28, 2024 · 0 comments
Assignees

Comments

@cwschilly
Copy link
Contributor

As mentioned in PR #546

CriterionBase defines an estimate method, but it may not be used.

  • TemperedCriterion doesn't implement it at all (which causes a pylint warning)
  • StrictLocalizingCriterion implements it by simply forwarding it to the compute function:
def estimate(self, r_src: Rank, o_src: list, *args) -> float:
        """Estimate is compute because all information is local for this criterion."""
        return self.compute(r_src, o_src, *args)

Investigate if we can just remove the estimate method entirely.

@cwschilly cwschilly self-assigned this Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant