diff --git a/src/vt-tv/api/object_communicator.h b/src/vt-tv/api/object_communicator.h index c93801f489..0b99e7e7fe 100644 --- a/src/vt-tv/api/object_communicator.h +++ b/src/vt-tv/api/object_communicator.h @@ -50,36 +50,6 @@ struct ObjectCommunicator { sent_(sent_in) { } - /** - * \brief Summarize one-way communicator properties and check for errors. - * - * \param[in] direction the direction to summarize edges - */ - std::vector summarizeUnidirectional(std::string direction) const { - // Initialize list of volumes - std::vector volumes; - - // Iterate over one-way communications - std::multimap communications; - if(direction == "to") { - communications = this->sent_; - } else { - communications = this->received_; - } - - // for (const auto& [key, value] : communications) { - // sanity check - // if(key->get_id() == this->object_id_) { - // throw nb::index_error( - // "object " + this->object_id_ + - // " cannot send communication to itself."); - // } - // volumes.push_back(value); - // } - - return volumes; - } - /** * \brief Get the id of object for this communicator * @@ -127,19 +97,6 @@ struct ObjectCommunicator { return results; } - /** - * \brief Summarize communicator properties and check for errors. - */ - std::pair, std::vector> summarize() const { - // Summarize sent communications - std::vector w_sent = this->summarizeUnidirectional("to"); - - // Summarize received communications - std::vector w_recv = this->summarizeUnidirectional("from"); - - return std::make_pair(w_sent, w_recv); - } - /** * \brief Add received edge * diff --git a/tests/unit/api/test_object_communicator.cc b/tests/unit/api/test_object_communicator.cc index 5632db083c..6f7d65957c 100644 --- a/tests/unit/api/test_object_communicator.cc +++ b/tests/unit/api/test_object_communicator.cc @@ -115,28 +115,6 @@ TEST_F(ObjectCommunicatorTest, test_initial_state) { EXPECT_EQ(comm_1.getTotalSentVolume(), 50.0); } -/** - * Test ObjectCommunicator initial state - */ -TEST_F(ObjectCommunicatorTest, test_summarize_communications_count_empty_communicator) { - // std::make_pair(w_sent, w_recv); - auto summary = comm_0.summarize(); - EXPECT_EQ(summary.first.size(), 0); - EXPECT_EQ(summary.second.size(), 0); -} - -/** - * Test ObjectCommunicator initial state - */ -TEST_F(ObjectCommunicatorTest, test_summarize_communications_count) { - GTEST_SKIP() << "ObjectCommunicator::summarize seems in WIP and is never called"; - - // std::make_pair(w_sent, w_recv); - auto summary = comm_0.summarize(); - EXPECT_EQ(summary.first.size(), 3); - EXPECT_EQ(summary.second.size(), 2); -} - TEST_F(ObjectCommunicatorTest, test_serialization) { BasicSerializer>> s = BasicSerializer>>();