Implement vt's style guidelines

[cwschilly]

As mentioned in this comment by @nlslatt

[tlamonthezie]

Hello @cwschilly it seems that the script generating the header in .h and .cc files has already been integrated in #85
Is there anything else related to guidelines in the current issue ?

[cwschilly]

Hi @tlamonthezie

Yes the license issue should be resolved. The remaining work on this issue is to go through the vt-tv code and make sure that all style guidelines from vt are being followed.

For reference:

• vt's style guidelines
• vt's Doxygen style guidelines
• vt's .clang_format file

[tlamonthezie]

Checks for src and tests directories

1. clang-format

• Add .clang-format configuration file from vt (edit: std must be c++17)
• Format files using clang-format

2. vt's style guidelines:

• Do not use "typedef", always use "using"
• Prefer "struct" over "class
• Wrap typename args when they get long, start ">" on next line
• Use an enum struct when possible
• A new line should be after the template
• Makes it easier to identify the full namespace path (nested namespace in 1 line as possible). Edit: Because std is C++17, prefer use namespace A::B {} over namespace A { namespace B { } } and make it consistent.

3. vt's Doxygen style guidelines

• Do some checks about doxygen styles (src directory)

[tlamonthezie]

@cwschilly @lifflander I noticed that in the header the licence contains the line "// Copyright 2019-2024 National Technology & Engineering Solutions of Sandia, LLC" which is 81 characters length. This is not compliant with the 80 char max per line guideline.
Should we break that line before "LLC" ?
Note: this is also the case in vt

[cwschilly]

@tlamonthezie We probably want to stick with whatever vt is using--even if it goes past 80 char