Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2387: Gather hashed trace user events at the end of run #2395

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

#2387: Gather hashed trace user events at the end of run #2395

wants to merge 7 commits into from

Conversation

cwschilly
Copy link
Contributor

Fixes #2387

Work in progress

@cwschilly cwschilly linked an issue Jan 10, 2025 that may be closed by this pull request
Hashed trace user events should do an all-reduce at the end instead of sending pt2pts to rank 0 during the run #2387
Open
@cwschilly cwschilly self-assigned this Jan 10, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

Pipelines results

PR tests (gcc-12, ubuntu, mpich, verbose, kokkos)

Build for bef9f41 (2025-01-20 21:39:35 UTC)

FAILED: src/CMakeFiles/vt.dir/Unity/unity_1_cxx.cxx.o 
/usr/bin/ccache /usr/lib/ccache/g++ -DJSON_USE_IMPLICIT_CONVERSIONS=1 -DKOKKOS_DEPENDENCE -DMAGISTRATE_KOKKOS_ENABLED=1 -DMAGISTRATE_KOKKOS_KERNELS_ENABLED=0 -DVT_NO_COLOR_ENABLED -I/vt/lib/CLI -I/build/vt/release -I/vt/src -I/vt/lib/json/include -I/vt/lib/brotli/c/include -I/vt/lib/libfort/lib -isystem /vt/lib/fmt/include -isystem /vt/lib/EngFormat-Cpp/include -isystem /build/checkpoint/install/include -isystem /build/kokkos/build/install/include -isystem /vt/lib/yaml-cpp/include -O3 -DNDEBUG -Wall -Wextra -Wno-unknown-pragmas -Wnon-virtual-dtor -Wshadow -Wsign-compare -Wsuggest-override -pedantic -ftemplate-backtrace-limit=100 -Werror -std=c++17 -MD -MT src/CMakeFiles/vt.dir/Unity/unity_1_cxx.cxx.o -MF src/CMakeFiles/vt.dir/Unity/unity_1_cxx.cxx.o.d -o src/CMakeFiles/vt.dir/Unity/unity_1_cxx.cxx.o -c /build/vt/src/CMakeFiles/vt.dir/Unity/unity_1_cxx.cxx
In file included from /vt/src/vt/registry/auto/auto_registry_common.h:51,
                 from /vt/src/vt/registry/auto/auto_registry_interface.h:47,
                 from /vt/src/vt/messaging/active.h:61,
                 from /vt/src/vt/pipe/callback/handler_send/callback_send_tl.impl.h:53,
                 from /vt/src/vt/pipe/callback/handler_send/callback_send_tl.h:86,
                 from /vt/src/vt/pipe/callback/cb_union/cb_raw.h:48,
                 from /vt/src/vt/pipe/callback/cb_union/cb_raw_base.h:48,
                 from /vt/src/vt/pipe/pipe_callback_only.h:47,
                 from /vt/src/vt/collective/reduce/operators/default_op.h:60,
                 from /vt/src/vt/collective/reduce/operators/default_msg.h:48,
                 from /vt/src/vt/collective/collective_alg.h:53,
                 from /vt/src/vt/collective/collective_alg.cc:44,
                 from /build/vt/src/CMakeFiles/vt.dir/Unity/unity_1_cxx.cxx:7:
/vt/src/vt/trace/trace.h:129:27: error: 'vt::objgroup::proxy' has not been declared
  129 |   void setProxy(objgroup::proxy::Proxy<Trace> in_proxy);
      |                           ^~~~~
/vt/src/vt/trace/trace.h:129:39: error: expected ',' or '...' before '<' token
  129 |   void setProxy(objgroup::proxy::Proxy<Trace> in_proxy);
      |                                       ^
/vt/src/vt/trace/trace.h:417:13: error: 'proxy' in namespace 'vt::objgroup' does not name a type
  417 |   objgroup::proxy::Proxy<Trace> proxy_;
      |             ^~~~~
/vt/src/vt/trace/trace.h: In member function 'void vt::trace::Trace::serialize(SerializerT&)':
/vt/src/vt/trace/trace.h:393:9: error: 'proxy_' was not declared in this scope
  393 |       | proxy_
      |         ^~~~~~
FAILED: src/CMakeFiles/vt.dir/Unity/unity_2_cxx.cxx.o 
/usr/bin/ccache /usr/lib/ccache/g++ -DJSON_USE_IMPLICIT_CONVERSIONS=1 -DKOKKOS_DEPENDENCE -DMAGISTRATE_KOKKOS_ENABLED=1 -DMAG%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

@cwschilly cwschilly changed the title #2387: Allreduce hashed trace user events at the end of run #2387: Gather hashed trace user events at the end of run Jan 13, 2025
@cwschilly cwschilly force-pushed the 2387-hashed-trace-user-events-should-do-an-all-reduce-at-the-end-instead-of-sending-pt2pts-to-rank-0-during-the-run branch from 1742430 to 7ee3b85 Compare January 20, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cwschilly cwschilly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hashed trace user events should do an all-reduce at the end instead of sending pt2pts to rank 0 during the run
1 participant
@cwschilly