Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine if we want to keep UploadServiceImp.processUploadRules() #47

Open
JustinKyleJames opened this issue Dec 16, 2024 · 1 comment
Assignees
Milestone

Comments

@JustinKyleJames
Copy link
Contributor

This code is pretty specific. It looks like most of the calls are to automatically populate metadata.

It would seem that the server rules would be a more appropriate place to trigger these rules to execute.

Here are the rules that are explicitly called.

		rs.execBamCramMetadataRule(host, objPath, filePath);
		rs.execVCFMetadataRule(host, objPath, filePath);
		rs.execPopulateMetadataRule(host, objPath);
		rs.execImageRule(host, objPath, filePath);
		rs.execIlluminaMetadataRule(dgDestResc, targetPath, objPath);
		rs.execManifestFileRule(host, targetPath, objPath, filePath);
@korydraughn
Copy link
Collaborator

Agreed. Torch it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants