Move sys_call from cryptlib_mbedtls to mbedtlslib

[rw8896]

https://github.com/DMTF/libspdm/tree/main/os_stub/cryptlib_mbedtls/sys_call

The functions in sys_call folder are actually part of mbedtlslib as specified in mbedtlslib/include/mbedtls/config.h.
For example,

libspdm/os_stub/mbedtlslib/include/mbedtls/config.h

Lines 188 to 193 in 62ba20e

	#define MBEDTLS_PLATFORM_MEMORY
	#include <stddef.h>
	extern void *my_calloc( size_t n, size_t size );
	extern void my_free( void *ptr );
	#define MBEDTLS_PLATFORM_CALLOC_MACRO my_calloc
	#define MBEDTLS_PLATFORM_FREE_MACRO my_free

These functions are not needed when integrators use their existing mbedtls libraries instead of building mbedtlslib

I am not familiar with openssl but I guess the same might also apply.

[jyao1]

Do you mean remove MACRO and only define mbedtls_calloc and mbedtls_free ?

[jyao1]

Maybe @rw8896 can you propose a patch?

[rw8896]

Functions under os_stub/cryptlib_mbedtls/sys_call are implemented because of the macros defined in libspdm/os_stub/mbedtlslib/include/mbedtls/config.h.

So I guess these sys_call functions should be part of mbedtlslib rather than cryptlib_mbedtls?

[jyao1]

@rw8896 would you please propose a patch?

[rw8896]

@rw8896 would you please propose a patch?

Sure, will do.

[rw8896]

@jyao1
Originally I planned to move sys_call from cryptlib_mbedtls to somewhere, e.g. os_stub/mbedtlslib/sys_call , but that would need to create a new library, probably not a good idea?

Do you have any suggestion? Or just leave it as it is now?

Thanks!