Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error code for unsupported RequesterInfo in CSR requests #2903

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Update error code for unsupported RequesterInfo in CSR requests #2903

merged 1 commit into from
Nov 22, 2024

Conversation

ShitalJumbad
Copy link
Contributor

Fix #2893

@ShitalJumbad ShitalJumbad marked this pull request as ready for review November 18, 2024 22:54
@steven-bellock
Copy link
Contributor

@rw8896 to review as well.

rw8896
rw8896 reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@rw8896 rw8896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current change looks good to me as the final solution is expected to be done after we change the return value of libspdm_gen_csr().

steven-bellock
steven-bellock approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@steven-bellock steven-bellock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make a follow-up issue / pull request for #2893 (comment).

@steven-bellock steven-bellock merged commit 98ef964 into DMTF:main Nov 22, 2024
97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rw8896 rw8896 rw8896 left review comments

@jyao1 jyao1 jyao1 approved these changes

@steven-bellock steven-bellock steven-bellock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GET_CSR: responder is not able to return InvalidRequest if any RequesterInfo content is not supported
4 participants
@ShitalJumbad @steven-bellock @jyao1 @rw8896