Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check ENCRYPT_CAP / MAC_CAP / KEY_EX_CAP #2944

Closed
steven-bellock opened this issue Jan 6, 2025 · 0 comments · Fixed by #2945
Closed

Check ENCRYPT_CAP / MAC_CAP / KEY_EX_CAP #2944

steven-bellock opened this issue Jan 6, 2025 · 0 comments · Fixed by #2945
Assignees
@steven-bellock
Labels
bug Something isn't working

Comments

@steven-bellock
Copy link
Contributor

From DMTF/SPDM-Responder-Validator#140.

Through #2921 the checking of MAC_CAP was deferred to when KEY_EXCHANGE was called. However the CAPABILITIES check still needs to enforce

KEY_EX_CAP - If set, Requester shall support KEY_EXCHANGE request message. If set, ENCRYPT_CAP or MAC_CAP shall be set.
@steven-bellock steven-bellock added the bug Something isn't working label Jan 6, 2025
@steven-bellock steven-bellock self-assigned this Jan 6, 2025
@steven-bellock steven-bellock mentioned this issue Jan 6, 2025
Closed
steven-bellock added a commit to steven-bellock/libspdm that referenced this issue Jan 6, 2025
@steven-bellock
Enforce MAC/ENCRYPT capability checks
c91e38f 
Fix DMTF#2944.

This also adds back relevant unit tests that were removed in DMTF#2933.

Signed-off-by: Steven Bellock <[email protected]>
@steven-bellock steven-bellock mentioned this issue Jan 6, 2025
Merged
steven-bellock added a commit to steven-bellock/libspdm that referenced this issue Jan 6, 2025
@steven-bellock
Enforce MAC/ENCRYPT capability checks
e08de37 
Fix DMTF#2944.

This also adds back relevant unit tests that were removed in DMTF#2933.

Signed-off-by: Steven Bellock <[email protected]>
jyao1 pushed a commit that referenced this issue Jan 9, 2025
@steven-bellock @jyao1
Enforce MAC/ENCRYPT capability checks
9b636f5 
Fix #2944.

This also adds back relevant unit tests that were removed in #2933.

Signed-off-by: Steven Bellock <[email protected]>
ShitalJumbad pushed a commit to ShitalJumbad/libspdm that referenced this issue Jan 22, 2025
@steven-bellock @ShitalJumbad
Enforce MAC/ENCRYPT capability checks
d84eeb8 
Fix DMTF#2944.

This also adds back relevant unit tests that were removed in DMTF#2933.

Signed-off-by: Steven Bellock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steven-bellock steven-bellock

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce MAC/ENCRYPT capability checks steven-bellock/libspdm
1 participant
@steven-bellock