Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPDM_ALGORITHMS_KEY_SCHEDULE_HMAC_HASH should be renamed #2951

Closed
steven-bellock opened this issue Jan 13, 2025 · 0 comments · Fixed by #2956
Closed

SPDM_ALGORITHMS_KEY_SCHEDULE_HMAC_HASH should be renamed #2951

steven-bellock opened this issue Jan 13, 2025 · 0 comments · Fixed by #2956
Assignees
@steven-bellock
Labels
enhancement New feature or request

Comments

@steven-bellock
Copy link
Contributor

libspdm/include/industry_standard/spdm.h

Lines 404 to 405 in 5ebe5e3

/* SPDM NEGOTIATE_ALGORITHMS request KEY_SCHEDULE */
#define SPDM_ALGORITHMS_KEY_SCHEDULE_HMAC_HASH 0x00000001

should be SPDM_ALGORITHMS_KEY_SCHEDULE_SPDM:

  • Byte 0 Bit 0. SPDM key schedule.
@steven-bellock steven-bellock added the enhancement New feature or request label Jan 13, 2025
@steven-bellock steven-bellock self-assigned this Jan 13, 2025
steven-bellock added a commit to steven-bellock/libspdm that referenced this issue Jan 13, 2025
@steven-bellock
Rename key schedule macro
5c5bf29 
Fix DMTF#2951.

Signed-off-by: Steven Bellock <[email protected]>
@steven-bellock steven-bellock mentioned this issue Jan 13, 2025
Merged
steven-bellock added a commit to steven-bellock/libspdm that referenced this issue Jan 14, 2025
@steven-bellock
Rename key schedule macro
3b0a2e8 
Fix DMTF#2951.

Signed-off-by: Steven Bellock <[email protected]>
@jyao1 jyao1 closed this as completed in 2c4d949 Jan 15, 2025
ShitalJumbad pushed a commit to ShitalJumbad/libspdm that referenced this issue Jan 22, 2025
@steven-bellock @ShitalJumbad
Rename key schedule macro
ed476a0 
Fix DMTF#2951.

Signed-off-by: Steven Bellock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steven-bellock steven-bellock

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename key schedule macro steven-bellock/libspdm
1 participant
@steven-bellock