Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when 2 procedures in the same file are named the same but have different parameters #556

Open
harold-b opened this issue Dec 29, 2024 · 3 comments

Comments

@harold-b
Copy link
Contributor

Happening in fded19f (master as of this writing).

It crashes here. Where the symbol value here appears to be corrupted.

Minimal reproduction case:

package bug

Foo :: struct {

}

foo_fn :: proc( foo: ^Foo, path: string ) {

}

foo_fn :: proc( foo: ^Foo, index: int ) {
    foo // <- Add a dot here to trigger
}

Adding the . triggers the completion request which triggers the crash.

@DanielGavin
Copy link
Owner

I have tried both Windows and Linux and the repro doesn't crash for me.

Were you on MacOS?

@harold-b
Copy link
Contributor Author

Yes, on macOS.

I can test on windows today to see if it reproduces for me locally.

@harold-b
Copy link
Contributor Author

harold-b commented Dec 29, 2024

I can confirm it's not triggering on Windows.

Both symbols on Windows have valid data. On macOS, the second symbol is corrupted, including the signature (second symbol crashes during signature resolution, so of course it's missing).

First symbol:
image

Second, corrupted, sybmol:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants