bc command not found error in DTS

[m-iwanicki]

Component

Dasharo Tools Suite

Device

NovaCustom NS5x 11th Gen, other

Dasharo version

No response

Dasharo Tools Suite version

v2.1.0

Test case ID

No response

Brief summary

Missing command error shown during initial deployment

How reproducible

100%

How to reproduce

Try to install Dasharo on Intel platform

Expected behavior

No errors

Actual behavior

/usr/sbin/dts-functions.sh: line 1654: bc: command not found

Screenshots

No response

Additional context

This PR was closed Dasharo/meta-dts#139 (adds missing bc command) but this dts-scripts PR Dasharo/dts-scripts#15 was merged (uses bc command).
@PLangowski should we reverse those commits?

Solutions you've tried

No response

[PLangowski]

The checks don't really work like they're supposed to, as mentioned in #1129.
Perhaps for now we should get rid of those checks? @miczyg1 cc

[miczyg1]

Well, they work as long as ME is visible and only for a subset of platforms. Older platforms have different FWSTS registers layout and the checks would have to be more specific for platforms. I guess we may just care about the platforms we support in DTS, which should make things a bit easier.

[m-iwanicki]

As of now check_if_fused and check_if_boot_guard_enabled always returns false because of missing bc command.

[PLangowski]

Ok, we should then add bc back to DTS

[PLangowski]

Dasharo/meta-dts#209

[m-iwanicki]

Older platforms have different FWSTS registers layout and the checks would have to be more specific for platforms. I guess we may just care about the platforms we support in DTS, which should make things a bit easier.

And do those checks work for all platforms we currently support?
Those questions will probably be asked again and again, because those checks are completely undocumented.

[PLangowski]

@m-iwanicki I think the error only appeared on Minnowboard, which we decided not to support.