Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some model names changed in SnipeIT, osfv_cli does not recognize them #91

Open
philipandag opened this issue Jan 14, 2025 · 0 comments · May be fixed by #92
Open

Some model names changed in SnipeIT, osfv_cli does not recognize them #91

philipandag opened this issue Jan 14, 2025 · 0 comments · May be fixed by #92

Comments

@philipandag
Copy link
Contributor

philipandag commented Jan 14, 2025 •
edited
Loading

Some model names changed in SnipeIT, osfv_cli does not recognize them. I've found that the MSI Z790-p DDR5 is no longer "supported" because it's name has changed. There might be more broken configurations there.

Traceback (most recent call last):
  File "/home/fgolas/work/open-source-firmware-validation2/venv/lib/python3.12/site-packages/osfv/rf/rte_robot.py", line 52, in __init__
    self.rte = RTE(rte_ip, dut_model_name, self.sonoff)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/fgolas/work/open-source-firmware-validation2/venv/lib/python3.12/site-packages/osfv/libs/rte.py", line 39, in __init__
    self.dut_data = self.load_model_data()
                    ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/fgolas/work/open-source-firmware-validation2/venv/lib/python3.12/site-packages/osfv/libs/rte.py", line 50, in load_model_data
    raise UnsupportedDUTModel(f"The {file_path} model is not yet supported")
osfv.libs.rte.UnsupportedDUTModel: The /home/fgolas/work/open-source-firmware-validation2/venv/lib/python3.12/site-packages/osfv/models/MSI PRO Z790-P WIFI DDR5.yml model is not yet supported

MSI PRO Z790-P WIFI DDR5 is the name received from SnipeIT, but there is only a config for MSI PRO Z790-P DDR5.

RTE constructor called by RobotRTE constructor at src/osfv/rf/rte_robot.py:54
The dut_model_name is received via snipe-it api

asset_id = self.snipeit_api.get_asset_id_by_rte_ip(rte_ip)
status, dut_model_name = self.snipeit_api.get_asset_model_name(
    asset_id
)

Either the names at SnipeIT need to be reverted or the model config names need to be updated
@philipandag philipandag linked a pull request Jan 14, 2025 that will close this issue
Update model names according to recent SnipeIT renamings #92
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update model names according to recent SnipeIT renamings Dasharo/osfv-scripts
1 participant
@philipandag