From eb19f98848475436d7cb41f22ef772fed3080220 Mon Sep 17 00:00:00 2001 From: Steven Bouwkamp Date: Wed, 23 Oct 2024 14:23:18 -0400 Subject: [PATCH] Limit tested behavior to just `cache_key` expects Co-authored-by: Marco Costa --- .../tracing/contrib/rails/cache_spec.rb | 31 ------------------- 1 file changed, 31 deletions(-) diff --git a/spec/datadog/tracing/contrib/rails/cache_spec.rb b/spec/datadog/tracing/contrib/rails/cache_spec.rb index 67aeb9bb06f..7afaa8c3271 100644 --- a/spec/datadog/tracing/contrib/rails/cache_spec.rb +++ b/spec/datadog/tracing/contrib/rails/cache_spec.rb @@ -128,22 +128,7 @@ expect(spans).to have(2).items get, set = spans expect(get.name).to eq('rails.cache') - expect(get.type).to eq('cache') - expect(get.resource).to eq('GET') - expect(get.service).to eq('rails-cache') - expect(get.get_tag('rails.cache.backend')).to eq('file_store') expect(get.get_tag('rails.cache.key')).to be_nil - expect(set.name).to eq('rails.cache') - - expect(get.get_tag(Datadog::Tracing::Metadata::Ext::TAG_COMPONENT)) - .to eq('active_support') - expect(get.get_tag(Datadog::Tracing::Metadata::Ext::TAG_OPERATION)) - .to eq('cache') - - expect(set.get_tag(Datadog::Tracing::Metadata::Ext::TAG_COMPONENT)) - .to eq('active_support') - expect(set.get_tag(Datadog::Tracing::Metadata::Ext::TAG_OPERATION)) - .to eq('cache') end end @@ -187,23 +172,7 @@ expect(spans).to have(1 + multi_keys.size).items get = spans[0] expect(get.name).to eq('rails.cache') - expect(get.type).to eq('cache') - expect(get.resource).to eq('MGET') - expect(get.service).to eq('rails-cache') - expect(get.get_tag('rails.cache.backend')).to eq('file_store') expect(get.get_tag('rails.cache.keys')).to be_nil - expect(get.get_tag(Datadog::Tracing::Metadata::Ext::TAG_COMPONENT)) - .to eq('active_support') - expect(get.get_tag(Datadog::Tracing::Metadata::Ext::TAG_OPERATION)) - .to eq('cache') - - spans[1..-1].each do |set| - expect(set.name).to eq('rails.cache') - expect(set.get_tag(Datadog::Tracing::Metadata::Ext::TAG_COMPONENT)) - .to eq('active_support') - expect(set.get_tag(Datadog::Tracing::Metadata::Ext::TAG_OPERATION)) - .to eq('cache') - end end end