Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dh-make-golang estimate broken in Debian unstable #231

Closed
ottok opened this issue Nov 29, 2024 · 0 comments · Fixed by #240
Closed

dh-make-golang estimate broken in Debian unstable #231

ottok opened this issue Nov 29, 2024 · 0 comments · Fixed by #240

Comments

@ottok
Copy link
Contributor

ottok commented Nov 29, 2024

I am not sure if I should report this in Debian or GitHub, but starting here:

Currently, the version in Debian unstable (dh-make-golang 0.7.0-1) can't produce any estimates. All invocations (tried on 4 different packages) fail with:

# dh-make-golang estimate github.com/charmbracelet/glamour
go get: 0.00 KiBgo: -d flag is deprecated. -d=true is a no-op
go: modules disabled by GO111MODULE=off; see 'go help modules'
2024/11/29 04:57:29 estimate: go get: exit status 1
n-peugnet added a commit to n-peugnet/dh-make-golang that referenced this issue Jan 5, 2025
@n-peugnet
Fix dh-make-golang estimate
c307819 
As support for the gopath mode of "go get" has been removed in latest
versions of Go, we cannot use the GO111MODULE=off trick any more.
To fix the estimate command, we now download the sources of the repo
manually then run "go mod tidy" in the repo dir to make use of the
information contained in the go.mod file and download the dependencies.

For go packages that are not modules yet, we init ourselves a go module
using "go mod init".

Closes: Debian#159
Closes: Debian#231
@n-peugnet n-peugnet mentioned this issue Jan 5, 2025
Merged
n-peugnet added a commit to n-peugnet/dh-make-golang that referenced this issue Jan 5, 2025
@n-peugnet
Fix dh-make-golang estimate
5fda007 
As support for the gopath mode of "go get" has been removed in latest
versions of Go, we cannot use the GO111MODULE=off trick any more.
To fix the estimate command, we now download the sources of the repo
manually then run "go get" in the repo dir to make use of the
information contained in the go.mod file and download the dependencies.

For go packages that are not modules yet, we init ourselves a go module
using "go mod init".

Closes: Debian#159
Closes: Debian#231
n-peugnet added a commit to n-peugnet/dh-make-golang that referenced this issue Jan 5, 2025
@n-peugnet
Fix dh-make-golang estimate
b1485e6 
As support for the gopath mode of "go get" has been removed in latest
versions of Go, we cannot use the GO111MODULE=off trick any more.
To fix the estimate command, we now download the sources of the repo
manually then run "go get" in the repo dir to make use of the
information contained in the go.mod file and download the dependencies.

For go packages that are not modules yet, we init ourselves a go module
using "go mod init".

Closes: Debian#159
Closes: Debian#231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dh-make-golang estimate n-peugnet/dh-make-golang
1 participant
@ottok