From 1138a809dcbb9143344725f0db53c95991bc33fa Mon Sep 17 00:00:00 2001
From: Gary Yendell <gary.yendell@diamond.ac.uk>
Date: Fri, 31 Jan 2025 11:25:11 +0000
Subject: [PATCH] Add some tests

---
 tests/transport/epics/test_gui.py | 78 +++++++++++++++++++++++++++++++
 tests/transport/epics/test_ioc.py |  7 +--
 tests/util.py                     |  7 +++
 3 files changed, 86 insertions(+), 6 deletions(-)
 create mode 100644 tests/util.py

diff --git a/tests/transport/epics/test_gui.py b/tests/transport/epics/test_gui.py
index 45faba9..de7fb93 100644
--- a/tests/transport/epics/test_gui.py
+++ b/tests/transport/epics/test_gui.py
@@ -1,17 +1,25 @@
+import numpy as np
+import pytest
 from pvi.device import (
     LED,
     ButtonPanel,
+    ComboBox,
     Group,
     SignalR,
     SignalRW,
     SignalW,
     SignalX,
     SubScreen,
+    TextFormat,
     TextRead,
     TextWrite,
     ToggleButton,
 )
+from tests.util import ColourEnum
 
+from fastcs.attributes import AttrR, AttrRW, AttrW
+from fastcs.controller import Controller
+from fastcs.datatypes import Bool, Enum, Float, Int, String, Waveform
 from fastcs.transport.epics.gui import EpicsGUI
 
 
@@ -23,6 +31,61 @@ def test_get_pv(controller):
     assert gui._get_pv(["D", "E"], "F") == "DEVICE:D:E:F"
 
 
+@pytest.mark.parametrize(
+    "datatype, widget",
+    [
+        (Bool(), LED()),
+        (Int(), TextRead()),
+        (Float(), TextRead()),
+        (String(), TextRead(format=TextFormat.string)),
+        (Enum(ColourEnum), TextRead(format=TextFormat.string)),
+        # (Waveform(array_dtype=np.int32), None),
+    ],
+)
+def test_get_attribute_component_r(datatype, widget, controller):
+    gui = EpicsGUI(controller, "DEVICE")
+
+    assert gui._get_attribute_component([], "Attr", AttrR(datatype)) == SignalR(
+        name="Attr", read_pv="Attr", read_widget=widget
+    )
+
+
+@pytest.mark.parametrize(
+    "datatype, widget",
+    [
+        (Bool(), ToggleButton()),
+        (Int(), TextWrite()),
+        (Float(), TextWrite()),
+        (String(), TextWrite(format=TextFormat.string)),
+        (Enum(ColourEnum), ComboBox(choices=["RED", "GREEN", "BLUE"])),
+    ],
+)
+def test_get_attribute_component_w(datatype, widget, controller):
+    gui = EpicsGUI(controller, "DEVICE")
+
+    assert gui._get_attribute_component([], "Attr", AttrW(datatype)) == SignalW(
+        name="Attr", write_pv="Attr", write_widget=widget
+    )
+
+
+def test_get_attribute_component_none(mocker, controller):
+    gui = EpicsGUI(controller, "DEVICE")
+
+    mocker.patch.object(gui, "_get_read_widget", return_value=None)
+    mocker.patch.object(gui, "_get_write_widget", return_value=None)
+    assert gui._get_attribute_component([], "Attr", AttrR(Int())) is None
+    assert gui._get_attribute_component([], "Attr", AttrW(Int())) is None
+    assert gui._get_attribute_component([], "Attr", AttrRW(Int())) is None
+
+
+def test_get_read_widget_none():
+    assert EpicsGUI._get_read_widget(AttrR(Waveform(np.int32))) is None
+
+
+def test_get_write_widget_none():
+    assert EpicsGUI._get_write_widget(AttrW(Waveform(np.int32))) is None
+
+
 def test_get_components(controller):
     gui = EpicsGUI(controller, "DEVICE")
 
@@ -87,3 +150,18 @@ def test_get_components(controller):
             value="1",
         ),
     ]
+
+
+def test_get_components_none(mocker):
+    """Test that if _get_attribute_component returns none it is skipped"""
+
+    class TestController(Controller):
+        attr = AttrR(Int())
+
+    controller = TestController()
+    gui = EpicsGUI(controller, "DEVICE")
+    mocker.patch.object(gui, "_get_attribute_component", return_value=None)
+
+    components = gui.extract_mapping_components(controller.get_controller_mappings()[0])
+
+    assert components == []
diff --git a/tests/transport/epics/test_ioc.py b/tests/transport/epics/test_ioc.py
index b69f727..98f72b4 100644
--- a/tests/transport/epics/test_ioc.py
+++ b/tests/transport/epics/test_ioc.py
@@ -10,6 +10,7 @@
     TestSender,
     TestUpdater,
 )
+from tests.util import ColourEnum
 
 from fastcs.attributes import AttrR, AttrRW, AttrW
 from fastcs.controller import Controller
@@ -70,12 +71,6 @@ async def test_create_and_link_read_pv(mocker: MockerFixture):
     record.set.assert_called_once_with(1)
 
 
-class ColourEnum(enum.IntEnum):
-    RED = 0
-    GREEN = 1
-    BLUE = 2
-
-
 @pytest.mark.parametrize(
     "attribute,record_type,kwargs",
     (
diff --git a/tests/util.py b/tests/util.py
new file mode 100644
index 0000000..e08f606
--- /dev/null
+++ b/tests/util.py
@@ -0,0 +1,7 @@
+import enum
+
+
+class ColourEnum(enum.IntEnum):
+    RED = 0
+    GREEN = 1
+    BLUE = 2