Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up tests #998

Closed
DominicOram opened this issue Jan 21, 2025 · 0 comments · Fixed by #1000
Closed

Speed up tests #998

DominicOram opened this issue Jan 21, 2025 · 0 comments · Fixed by #1000
Assignees
@DominicOram

Comments

@DominicOram
Copy link
Contributor

We have a few tests that are taking >1s. We should speed them up:

============================================================================== slowest durations ===============================================================================
3.42s call     tests/test_cli.py::test_cli_version
3.01s call     tests/devices/unit_tests/test_focusing_mirror.py::test_mirror_set_voltage_sets_and_waits_settle_timeout_expires
1.02s call     tests/devices/unit_tests/test_apple2_undulator.py::test_phase_time_out_error
1.01s call     tests/devices/unit_tests/test_apple2_undulator.py::test_gap_time_out_error
1.01s call     tests/devices/unit_tests/test_apple2_undulator.py::test_jaw_phase_time_out_error

It's likely that the unit_tests ones are poor mocking but the test_cli_version maybe makes more sense moved to the system tests.

Acceptance Criteria

  • All unit tests take <1s
@DominicOram DominicOram self-assigned this Jan 22, 2025
@DominicOram DominicOram mentioned this issue Jan 22, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DominicOram DominicOram

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Speed up tests DiamondLightSource/dodal
1 participant
@DominicOram