We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apple2_undulator
There is quite a bit of repeated code in apple2_undulator that could be tidied up:
async def check_id_status(self) -> None:
_cal_timeout
UndulatorPhaseMotor
Motor
The text was updated successfully, but these errors were encountered:
DominicOram
Successfully merging a pull request may close this issue.
There is quite a bit of repeated code in
apple2_undulator
that could be tidied up:async def check_id_status(self) -> None:
_cal_timeout
is always doing the same basic thing of estimating motor timingsUndulatorPhaseMotor
is just an expanded motor record, can we inherit fromMotor
?Acceptance Criteria
apple2_undulator
is tidierThe text was updated successfully, but these errors were encountered: