Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce repeated code in apple2_undulator #999

Closed
DominicOram opened this issue Jan 22, 2025 · 0 comments · Fixed by #1002
Closed

Reduce repeated code in apple2_undulator #999

DominicOram opened this issue Jan 22, 2025 · 0 comments · Fixed by #1002
Assignees

Comments

@DominicOram
Copy link
Contributor

There is quite a bit of repeated code in apple2_undulator that could be tidied up:

  • Multiple async def check_id_status(self) -> None:
  • _cal_timeout is always doing the same basic thing of estimating motor timings
  • UndulatorPhaseMotor is just an expanded motor record, can we inherit from Motor?

Acceptance Criteria

  • apple2_undulator is tidier
  • Behavior is unchanged
@DominicOram DominicOram self-assigned this Jan 22, 2025
@DominicOram DominicOram mentioned this issue Jan 23, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant