Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown User error when filtering dates #113

Closed
danieldegroot2 opened this issue Apr 1, 2023 · 5 comments
Closed

Unknown User error when filtering dates #113

danieldegroot2 opened this issue Apr 1, 2023 · 5 comments
Labels

Comments

@danieldegroot2
Copy link

Viewing around Wroclaw, Poland and filtering notes to the month of March 2023 (all users, 1-31 March, only selected area) causes registered users' names to be displayed as Unknown User. This may be due to a note causing a javascript error?

@maro-21
Copy link

maro-21 commented Apr 1, 2023

Where can you see that error?

@ENT8R
Copy link
Owner

ENT8R commented Apr 1, 2023

The problem is likely that a user commented on some note in the area and after that they deleted their account. If the user details are then requested via the API by NotesReview, this leads to an error and no details of any user can be shown.
I already noticed this bug a few months ago, but did not take any action yet, as I am not quite sure whether this requires a change on my side or a fix of the OpenStreetMap API.

Basically the problem is the following:
Requesting the details of the users with the ids 18597840 and 185978900 fails with a 404 whereas limiting the query to user 18597840 returns the correct result because user 185978900 commented on a note and deleted their account afterwards.

@ENT8R ENT8R added bug blocked Waiting for another feature to be added (either internal or external) labels Apr 1, 2023
@danieldegroot2
Copy link
Author

Ok, then we wait until openstreetmap/openstreetmap-website#2146 / openstreetmap/openstreetmap-website#3831 / related PRs gets out of its current stall, or until @gravitystorm or someone else is able to give a hint.

@ENT8R ENT8R removed the blocked Waiting for another feature to be added (either internal or external) label Oct 28, 2023
@ENT8R
Copy link
Owner

ENT8R commented Oct 28, 2023

This has been fixed for about two months now (requesting the user details of a deleted user does no longer fail, instead an empty response is returned by the API)

@ENT8R ENT8R closed this as completed Oct 28, 2023
@danieldegroot2
Copy link
Author

danieldegroot2 commented Oct 29, 2023

Thanks for the update.
Ref openstreetmap/openstreetmap-website#4190

Related issues/PRs are still open.
See also osmfoundation/ewg_bidding#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants