Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to update CAM7 suite SDF to use constituent tendency updater #179

Closed
jimmielin opened this issue Dec 14, 2024 · 0 comments · Fixed by #188
Closed

Need to update CAM7 suite SDF to use constituent tendency updater #179

jimmielin opened this issue Dec 14, 2024 · 0 comments · Fixed by #188
Assignees
@jimmielin
Labels
bug Something isn't working

Comments

@jimmielin
Copy link
Member

jimmielin commented Dec 14, 2024 •
edited
Loading

suite_cam7.xml currently uses dadadj_apply_qv_tendency after dry adiabatic adjustment causing build failure. need to update to use constituent tendency updater

#178 will update suite_cam7.xml to address this
@jimmielin jimmielin added the bug Something isn't working label Dec 14, 2024
@jimmielin jimmielin self-assigned this Dec 16, 2024
@jimmielin jimmielin changed the title Need to CAM7 suite to use constituent tendency updater Need to update CAM7 suite SDF to use constituent tendency updater Dec 16, 2024
@jimmielin jimmielin mentioned this issue Jan 6, 2025
Merged
peverwhee added a commit that referenced this issue Jan 8, 2025
@peverwhee
Use new constituent tendency updater in cam7 SDF (#188)
74e905b 
Originator(s): peverwhee

Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue
number):

Uses new constituent tendency updater scheme
(apply_constituent_tendencies) instead of the temporary dry adiabatic
adjustment updater (that no longer exists!)

closes #179 

Describe any changes made to the namelist: N/A

List all files eliminated and why: N/A

List all files added and what they do:

List all existing files that have been modified, and describe the
changes:
(Helpful git command: git diff --name-status
development...<your_branch_name>)

M suites/suite_cam7.xml
- use apply_constituent_tendencies scheme

List any test failures: n/a

Is this a science-changing update? New physics package, algorithm
change, tuning changes, etc? No
@github-project-automation github-project-automation bot moved this from To Do to Done in CAM Development Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimmielin jimmielin

Labels
bug Something isn't working
Projects
CAM Development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use new constituent tendency updater in cam7 SDF peverwhee/atmospheric_physics
1 participant
@jimmielin