Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: normalize to stringify ? #49

Open
albop opened this issue Mar 13, 2018 · 4 comments
Open

REF: normalize to stringify ? #49

albop opened this issue Mar 13, 2018 · 4 comments

Comments

@albop
Copy link
Member

albop commented Mar 13, 2018

@sglyon, we have been accused of namespace hijacking (or something like that). What about renaming normalize to stringify ?

@sglyon
Copy link
Member

sglyon commented Mar 13, 2018

I'd be ok with that. It would be nice to have a name that can't really mean anything else (I mean you just made it up!)

@albop
Copy link
Member Author

albop commented Mar 13, 2018

OK then. So, we have:

  • sanitize which adds timing at t=0 (I actually wonder whether we should normalize as (a(t)) instead of a(0), but that could be changed later as an internal detail).
  • stringify, which translates expressions into expression of basic flat symbols. (We could also consider flatify since we are allowed to make up names and flatten is already taken by reasonable people)

@sglyon
Copy link
Member

sglyon commented Mar 13, 2018

I'm probably understanding wrong, but I thought we were thinking about how to not use the word normalize as a function name. Is that the goal?

@albop
Copy link
Member Author

albop commented Mar 13, 2018

sorry my mistake, I meant that we know have sanitize and stringify and was wondering whether both were correct (I updated the comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants